RESOLVED INVALID133387
Compatibility hack to make GitX less crashy 
https://bugs.webkit.org/show_bug.cgi?id=133387
Summary Compatibility hack to make GitX less crashy
Mark Lam
Reported 2014-05-29 14:19:25 PDT
The GitX app is using WebCore on a different thread than the main thread. This results in crashes because WebKit is a main-thread only API. This patch implements a MAC only hack to make GitX less crashy by forcing the use of the JSLock when entering the JSC VM if the app bundle is GitX.
Attachments
the patch. (2.45 KB, patch)
2014-05-29 15:17 PDT, Mark Lam 		ggaren: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-05-29 14:19:57 PDT
<rdar://problem/17008429>
Mark Lam
Comment 3 2014-05-29 15:17:28 PDT
Created attachment 232266 [details] the patch.
Geoffrey Garen
Comment 4 2014-05-29 15:33:19 PDT
Comment on attachment 232266 [details] the patch. Alexey and MarkR discovered that this was a temporary regression caused by a notification firing on a secondary thread. We don't need this workaround. We need the notification to fire on the main thread instead.
Note You need to log in before you can comment on or make changes to this bug.