Bug 133387 - Compatibility hack to make GitX less crashy
Summary: Compatibility hack to make GitX less crashy
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-29 14:19 PDT by Mark Lam
Modified: 2014-05-29 15:33 PDT (History)
3 users (show)

See Also:

Attachments
the patch. (2.45 KB, patch)
2014-05-29 15:17 PDT, Mark Lam 		ggaren: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-05-29 14:19:25 PDT 
The GitX app is using WebCore on a different thread than the main thread.  This results in crashes because WebKit is a main-thread only API.  This patch implements a MAC only hack to make GitX less crashy by forcing the use of the JSLock when entering the JSC VM if the app bundle is GitX.
Comment 1 Mark Lam 2014-05-29 14:19:57 PDT 
<rdar://problem/17008429>
Comment 3 Mark Lam 2014-05-29 15:17:28 PDT 
Created attachment 232266 [details]
the patch.
Comment 4 Geoffrey Garen 2014-05-29 15:33:19 PDT 
Comment on attachment 232266 [details]
the patch.

Alexey and MarkR discovered that this was a temporary regression caused by a notification firing on a secondary thread. We don't need this workaround. We need the notification to fire on the main thread instead.