Bug 133383 - Need to notify the keyboard about every KeyDown event
Summary: Need to notify the keyboard about every KeyDown event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-29 12:15 PDT by Enrica Casucci
Modified: 2014-05-30 10:55 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.68 KB, patch)
2014-05-29 12:22 PDT, Enrica Casucci
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-05-29 12:15:08 PDT
A key down will generate most of the time a call to the keyboard to add input or delete.
But the key down could be handled by JavaScript and its default prevented. We need to notify the keyboard in every case to allow updating its internal state about what has been typed.

<rdar://problem/16633975>
Comment 1 Enrica Casucci 2014-05-29 12:22:43 PDT
Created attachment 232258 [details]
Patch
Comment 2 Benjamin Poulain 2014-05-29 14:22:21 PDT
Comment on attachment 232258 [details]
Patch

Sure.
Comment 3 Enrica Casucci 2014-05-29 14:48:29 PDT
Committed revision 169466.