RESOLVED FIXED 133382
Support -apple-system-font on OS X 
https://bugs.webkit.org/show_bug.cgi?id=133382
Summary Support -apple-system-font on OS X
Myles C. Maxfield
Reported 2014-05-29 11:52:19 PDT
Support -apple-system-font on OS X
Attachments
Patch (3.56 KB, patch)
2014-05-29 11:56 PDT, Myles C. Maxfield 		simon.fraser: review+
simon.fraser: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-05-29 11:56:40 PDT
Created attachment 232257 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-05-29 12:00:41 PDT
Comment on attachment 232257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232257&action=review > LayoutTests/ChangeLog:11 > + * platform/mac/fast/text/apple-system-font-expected.html: Added. > + * platform/mac/fast/text/apple-system-font.html: Added. I think this ref test is bogus. You should extend the existing -webkit-system-font test.
mitz
Comment 3 2014-05-29 16:54:12 PDT
Comment on attachment 232257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232257&action=review > Source/WebCore/platform/mac/WebFontCache.mm:164 > - if ([desiredFamily compare:@"-webkit-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame) { > + if ([desiredFamily compare:@"-webkit-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame > + || [desiredFamily compare:@"-apple-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame) { Can we use stringIsCaseInsensitiveEqualToString() here instead?
Myles C. Maxfield
Comment 4 2014-05-29 17:06:14 PDT
http://trac.webkit.org/changeset/169474 Will use stringIsCaseInsensitiveEqualToString in a follow-up patch
Radar WebKit Bug Importer
Comment 5 2014-05-30 11:29:15 PDT
<rdar://problem/17080463>
Myles C. Maxfield
Comment 6 2014-05-30 14:01:25 PDT
Addressed Mitz' comments in http://trac.webkit.org/changeset/169492
Note You need to log in before you can comment on or make changes to this bug.