Bug 133376 - Remove repetitive header in HTMLInputElement.cpp
Summary: Remove repetitive header in HTMLInputElement.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-29 05:28 PDT by Prashant Hiremath
Modified: 2014-05-30 12:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2014-05-29 05:30 PDT, Prashant Hiremath 		no flags Details | Formatted Diff | Diff
Patch (1.51 KB, patch)
2014-05-29 05:39 PDT, Prashant Hiremath 		no flags Details | Formatted Diff | Diff
Patch (1.06 KB, patch)
2014-05-29 19:37 PDT, Prashant Hiremath 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Prashant Hiremath 2014-05-29 05:28:13 PDT 
RuntimeEnabledFeatures.h header file is added twice in file, So removing it. Also fixing webkit-style fix in file.
Comment 1 Prashant Hiremath 2014-05-29 05:30:58 PDT 
Created attachment 232242 [details]
Patch

proposed patch
Comment 2 WebKit Commit Bot 2014-05-29 05:32:07 PDT 
Attachment 232242 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Prashant Hiremath 2014-05-29 05:39:26 PDT 
Created attachment 232243 [details]
Patch

Fixed ChangeLog Error
Comment 4 Radu Stavila 2014-05-29 06:06:09 PDT 
Comment on attachment 232243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232243&action=review

> Source/WebCore/html/HTMLInputElement.cpp:856
>      if (renderer() && renderer()->style().hasAppearance())

Altough this is a correct style fix, I think you should stick to changes relevant to this particular issue (e.g. just the header inclusion removal)
Comment 5 Prashant Hiremath 2014-05-29 19:37:43 PDT 
Created attachment 232279 [details]
Patch

Removed Repeative headers only
Comment 6 WebKit Commit Bot 2014-05-30 12:27:25 PDT 
Comment on attachment 232279 [details]
Patch

Clearing flags on attachment: 232279

Committed r169491: <http://trac.webkit.org/changeset/169491>
Comment 7 WebKit Commit Bot 2014-05-30 12:27:28 PDT 
All reviewed patches have been landed.  Closing bug.