WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133374
Pass C++11 lambdas to callOnMainThread() calls in IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=133374
Summary
Pass C++11 lambdas to callOnMainThread() calls in IconDatabase
Zan Dobersek
Reported
2014-05-29 03:55:01 PDT
Pass C++11 lambdas to callOnMainThread() calls in IconDatabase
Attachments
Patch
(6.29 KB, patch)
2014-05-29 04:03 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch
(9.13 KB, patch)
2014-06-05 01:39 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2014-05-29 04:03:25 PDT
Created
attachment 232240
[details]
Patch
Darin Adler
Comment 2
2014-05-31 15:31:17 PDT
Comment on
attachment 232240
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=232240&action=review
> Source/WebCore/loader/icon/IconDatabase.cpp:2160 > + ImportedIconURLForPageURLWorkItem* itemPtr = new ImportedIconURLForPageURLWorkItem(m_client, pageURL);
Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead?
> Source/WebCore/loader/icon/IconDatabase.cpp:2171 > + ImportedIconDataForPageURLWorkItem* itemPtr = new ImportedIconDataForPageURLWorkItem(m_client, pageURL);
Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead?
> Source/WebCore/loader/icon/IconDatabase.cpp:2182 > + RemovedAllIconsWorkItem* itemPtr = new RemovedAllIconsWorkItem(m_client);
Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead?
> Source/WebCore/loader/icon/IconDatabase.cpp:2193 > + FinishedURLImport* itemPtr = new FinishedURLImport(m_client);
Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead?
Zan Dobersek
Comment 3
2014-06-05 01:39:47 PDT
Created
attachment 232530
[details]
Patch
Zan Dobersek
Comment 4
2014-06-05 01:48:48 PDT
(In reply to
comment #2
)
> (From update of
attachment 232240
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=232240&action=review
> > > Source/WebCore/loader/icon/IconDatabase.cpp:2160 > > + ImportedIconURLForPageURLWorkItem* itemPtr = new ImportedIconURLForPageURLWorkItem(m_client, pageURL); > > Does this allocation need to be done in the icon sync thread? Can it be done on the main thread instead?
I went on and removed all of these classes as they were just calling a specific method on the IconDatabaseClient in their performWork() override. Requesting a re-review because of that.
Zan Dobersek
Comment 5
2014-06-07 06:10:55 PDT
Comment on
attachment 232530
[details]
Patch Clearing flags on attachment: 232530 Committed
r169674
: <
http://trac.webkit.org/changeset/169674
>
Zan Dobersek
Comment 6
2014-06-07 06:11:02 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug