RESOLVED FIXED Bug 133367
AX: Add support for ARIA 1.1 'none' role 
https://bugs.webkit.org/show_bug.cgi?id=133367
Summary AX: Add support for ARIA 1.1 'none' role
James Craig
Reported 2014-05-28 18:19:51 PDT
"none" is a synonym of "presentation" in the ARIA 1.1 role list. http://rawgit.com/w3c/aria/master/spec/aria.html#none
Attachments
Patch to add support for the 'none' role in ARIA 1.1 (2.11 KB, patch)
2014-06-04 12:58 PDT, Michael Timbrook 		cfleizach: review-
DetailsFormatted DiffDiff
Updated patch with change log (3.32 KB, patch)
2014-06-05 11:53 PDT, Michael Timbrook 		no flags
DetailsFormatted DiffDiff
Updated patch with change log (3.32 KB, patch)
2014-06-05 11:54 PDT, Michael Timbrook 		timbrook: review+
DetailsFormatted DiffDiff
Updated patch with change log (3.32 KB, patch)
2014-06-05 11:55 PDT, Michael Timbrook 		no flags
DetailsFormatted DiffDiff
svn compatible patch (3.29 KB, patch)
2014-06-05 15:58 PDT, Michael Timbrook 		no flags
DetailsFormatted DiffDiff
adds aria 'none' role (3.29 KB, patch)
2014-06-05 16:11 PDT, Michael Timbrook 		no flags
DetailsFormatted DiffDiff
Added 'none' role (3.50 KB, patch)
2014-06-05 16:28 PDT, Michael Timbrook 		no flags
DetailsFormatted DiffDiff
added 'none' role (3.50 KB, patch)
2014-06-05 16:29 PDT, Michael Timbrook 		no flags
DetailsFormatted DiffDiff
added 'none' role (3.49 KB, patch)
2014-06-05 16:33 PDT, Michael Timbrook 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-05-28 18:20:13 PDT
<rdar://problem/17060103>
Michael Timbrook
Comment 2 2014-06-04 12:58:48 PDT
Created attachment 232493 [details] Patch to add support for the 'none' role in ARIA 1.1
chris fleizach
Comment 3 2014-06-05 11:00:27 PDT
Comment on attachment 232493 [details] Patch to add support for the 'none' role in ARIA 1.1 looks good, just include a change log for layout tests and webcore, by running ./Tools/Scripts/prepare-ChangeLog --bug=133367 when you upload the new patch make sure you set review ?
Michael Timbrook
Comment 4 2014-06-05 11:53:17 PDT
Created attachment 232569 [details] Updated patch with change log
Michael Timbrook
Comment 5 2014-06-05 11:54:09 PDT
Created attachment 232570 [details] Updated patch with change log
Michael Timbrook
Comment 6 2014-06-05 11:55:28 PDT
Created attachment 232571 [details] Updated patch with change log
Michael Timbrook
Comment 7 2014-06-05 15:58:42 PDT
Created attachment 232587 [details] svn compatible patch Made sure the patch would be accepted by svn
Michael Timbrook
Comment 8 2014-06-05 16:11:34 PDT
Created attachment 232590 [details] adds aria 'none' role
Michael Timbrook
Comment 9 2014-06-05 16:28:30 PDT
Created attachment 232591 [details] Added 'none' role
Michael Timbrook
Comment 10 2014-06-05 16:29:19 PDT
Created attachment 232592 [details] added 'none' role
Michael Timbrook
Comment 11 2014-06-05 16:33:17 PDT
Created attachment 232593 [details] added 'none' role
WebKit Commit Bot
Comment 12 2014-06-05 17:23:31 PDT
Comment on attachment 232593 [details] added 'none' role Clearing flags on attachment: 232593 Committed r169632: <http://trac.webkit.org/changeset/169632>
WebKit Commit Bot
Comment 13 2014-06-05 17:23:36 PDT
All reviewed patches have been landed. Closing bug.
chris fleizach
Comment 14 2014-06-13 08:44:56 PDT
*** Bug 133856 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.