Bug 133350 – Perserve caption selection in fullscreen.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

Perserve caption selection in fullscreen.

[Jeremy Jones]

radar://17046725

[Jeremy Jones]

Created attachment 232206 [details]
Patch

[Eric Carlson]

Comment on attachment 232206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232206&action=review

> Source/WebCore/ChangeLog:8
> +        Use the logic from the line player to calculate the selected caption index.

Nit: "from the line player" -> "from the inline player"

> Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:297
> +    if (trackList && m_mediaElement->document().page() && m_mediaElement->mediaControlsHost()) {

This should be an early return.

> Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:303
> +        Vector<String> legibleOptions;

Nit: I had to read through the code to figure out what "legibleOptions" meant, so something like "trackDisplayNames" might be better.

> Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:326
> +        if (offIndex && displayMode == MediaControlsHost::forcedOnlyKeyword() && !trackMenuItemSelected) {

Nit: "!trackMenuItemSelected" is cheaper than "displayMode == MediaControlsHost::forcedOnlyKeyword()" so it should be first.

[Jeremy Jones]

Created attachment 232222 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 232222 [details]
Patch

Clearing flags on attachment: 232222

Committed r169450: <http://trac.webkit.org/changeset/169450>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.