Bug 133347 - Remove redundant GraphicsContext::drawImage() function.
Summary: Remove redundant GraphicsContext::drawImage() function.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-28 09:01 PDT by zalan
Modified: 2014-05-30 07:17 PDT (History)
21 users (show)

See Also:

Attachments
Patch (9.25 KB, patch)
2014-05-28 09:20 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.79 KB, patch)
2014-05-28 09:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.87 KB, patch)
2014-05-29 18:59 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-05-28 09:01:43 PDT 
These 2 functions have very similar parameter list and by looking at WebCore code, people sometimes get confused which one to call. (and provide default values for parameters when they are not needed at all)

        void drawImage(Image*, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator = CompositeSourceOver, ImageOrientationDescription = ImageOrientationDescription(), bool useLowQualityScale = false);
        void drawImage(Image*, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator, BlendMode, ImageOrientationDescription = ImageOrientationDescription(), bool useLowQualityScale = false);
Comment 1 zalan 2014-05-28 09:20:33 PDT 
Created attachment 232201 [details]
Patch
Comment 2 zalan 2014-05-28 09:31:48 PDT 
Created attachment 232203 [details]
Patch
Comment 3 zalan 2014-05-29 18:59:01 PDT 
Created attachment 232277 [details]
Patch
Comment 4 zalan 2014-05-29 19:05:01 PDT 
A follow-up patch will consolidate the drawImage parameters to a struct.
Comment 5 Simon Fraser (smfr) 2014-05-29 21:51:29 PDT 
Comment on attachment 232277 [details]
Patch

ImageOrientationDescription() is so mysterious.
Comment 6 WebKit Commit Bot 2014-05-30 07:17:25 PDT 
Comment on attachment 232277 [details]
Patch

Clearing flags on attachment: 232277

Committed r169484: <http://trac.webkit.org/changeset/169484>
Comment 7 WebKit Commit Bot 2014-05-30 07:17:32 PDT 
All reviewed patches have been landed.  Closing bug.