RESOLVED FIXED 133347
Remove redundant GraphicsContext::drawImage() function. 
https://bugs.webkit.org/show_bug.cgi?id=133347
Summary Remove redundant GraphicsContext::drawImage() function.
zalan
Reported 2014-05-28 09:01:43 PDT
These 2 functions have very similar parameter list and by looking at WebCore code, people sometimes get confused which one to call. (and provide default values for parameters when they are not needed at all) void drawImage(Image*, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator = CompositeSourceOver, ImageOrientationDescription = ImageOrientationDescription(), bool useLowQualityScale = false); void drawImage(Image*, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator, BlendMode, ImageOrientationDescription = ImageOrientationDescription(), bool useLowQualityScale = false);
Attachments
Patch (9.25 KB, patch)
2014-05-28 09:20 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (10.79 KB, patch)
2014-05-28 09:31 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.87 KB, patch)
2014-05-29 18:59 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-05-28 09:20:33 PDT
Created attachment 232201 [details] Patch
zalan
Comment 2 2014-05-28 09:31:48 PDT
Created attachment 232203 [details] Patch
zalan
Comment 3 2014-05-29 18:59:01 PDT
Created attachment 232277 [details] Patch
zalan
Comment 4 2014-05-29 19:05:01 PDT
A follow-up patch will consolidate the drawImage parameters to a struct.
Simon Fraser (smfr)
Comment 5 2014-05-29 21:51:29 PDT
Comment on attachment 232277 [details] Patch ImageOrientationDescription() is so mysterious.
WebKit Commit Bot
Comment 6 2014-05-30 07:17:25 PDT
Comment on attachment 232277 [details] Patch Clearing flags on attachment: 232277 Committed r169484: <http://trac.webkit.org/changeset/169484>
WebKit Commit Bot
Comment 7 2014-05-30 07:17:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.