Bug 133325 - Move constructTextRun() from RenderBlock to RenderBox
Summary: Move constructTextRun() from RenderBlock to RenderBox
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-27 14:50 PDT by Myles C. Maxfield
Modified: 2015-11-13 10:26 PST (History)
1 user (show)

See Also:

Attachments
Patch (36.75 KB, patch)
2014-05-27 14:53 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-05-27 14:50:27 PDT 
Move constructTextRun() from RenderBlock to RenderBox
Comment 1 Myles C. Maxfield 2014-05-27 14:53:36 PDT 
Created attachment 232150 [details]
Patch
Comment 2 zalan 2014-06-10 18:59:31 PDT 
Comment on attachment 232150 [details]
Patch

Is there a reason why we keep these stateless functions around in a render class instead of a separate file?
Comment 3 Myles C. Maxfield 2014-06-11 14:32:35 PDT 
I am not 100% sure but my guess would be to keep relevant pieces nearby
Comment 4 Joseph Pecoraro 2015-11-12 21:37:48 PST 
Comment on attachment 232150 [details]
Patch

Does this patch still make sense?