Bug 133297 – Fix test failures on python test

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gyuyoung Kim]

There are 2 fails on python test because of unbounded local variable reference as below,


[1214/1422] webkitpy.w3c.test_importer_unittest.TestImporterTest.test_import_dir_with_no_tests_and_no_hg erred:
  Traceback (most recent call last):
    File "/home/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py", line 62, in test_import_dir_with_no_tests_and_no_hg
      importer.do_import()
    File "/home/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Tools/Scripts/webkitpy/w3c/test_importer.py", line 197, in do_import
      self.import_tests()
    File "/home/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Tools/Scripts/webkitpy/w3c/test_importer.py", line 377, in import_tests
      if len(failed_conversion_files):
  UnboundLocalError: local variable 'failed_conversion_files' referenced before assignment

[Gyuyoung Kim]

Created attachment 232109 [details]
Patch

[Dirk Schulze]

Comment on attachment 232109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232109&action=review

> Tools/ChangeLog:8
> +        2 tests are failed because of unbounded local variable reference in test_importer.py.

s/failed/failing/ or the other way around and remove "are".

[Gyuyoung Kim]

Committed r169369: <http://trac.webkit.org/changeset/169369>

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 232109 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232109&action=review
> 
> > Tools/ChangeLog:8
> > +        2 tests are failed because of unbounded local variable reference in test_importer.py.
> 
> s/failed/failing/ or the other way around and remove "are".

Patch is landed after fixing it. Thanks.

[Gyuyoung Kim]

For the record, this problem came from http://trac.webkit.org/changeset/169347.