Bug 133295 - CSS JIT: add support for the pseudo classes :hover and :active
Summary: CSS JIT: add support for the pseudo classes :hover and :active
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks: 133314
  Show dependency tree / graph
 
Reported: 2014-05-26 20:23 PDT by Benjamin Poulain
Modified: 2014-06-01 02:14 PDT (History)
13 users (show)

See Also:

Attachments
Patch (38.07 KB, patch)
2014-05-26 20:31 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-05-26 20:23:03 PDT 
CSS JIT: add support for the pseudo classes :hover and :active
Comment 1 Benjamin Poulain 2014-05-26 20:31:17 PDT 
Created attachment 232104 [details]
Patch
Comment 2 Andreas Kling 2014-05-27 10:22:39 PDT 
Comment on attachment 232104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232104&action=review

> Source/WebCore/dom/Document.cpp:767
> +void Document::setCompatibilityMode(DocumentCompatibilityMode mode)

Does this function need to do any additional invalidation?
Comment 3 Benjamin Poulain 2014-05-27 15:47:31 PDT 
(In reply to comment #2)
> (From update of attachment 232104 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232104&action=review
> 
> > Source/WebCore/dom/Document.cpp:767
> > +void Document::setCompatibilityMode(DocumentCompatibilityMode mode)
> 
> Does this function need to do any additional invalidation?

That should not be needed. With compiled selectors we don't even need the clearSelectorQueryCache(), it is just there for the old code.
Comment 4 Andreas Kling 2014-05-29 15:37:55 PDT 
Comment on attachment 232104 [details]
Patch

r=me
Comment 5 Benjamin Poulain 2014-05-29 17:15:44 PDT 
Comment on attachment 232104 [details]
Patch

Clearing flags on attachment: 232104

Committed r169478: <http://trac.webkit.org/changeset/169478>
Comment 6 Benjamin Poulain 2014-05-29 17:15:49 PDT 
All reviewed patches have been landed.  Closing bug.