RESOLVED FIXED133267
Use the right paths for website data 
https://bugs.webkit.org/show_bug.cgi?id=133267
Summary Use the right paths for website data
Anders Carlsson
Reported 2014-05-25 15:23:37 PDT
Use the right paths for website data
Attachments
Patch (4.13 KB, patch)
2014-05-25 15:24 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-05-25 15:24:45 PDT
Created attachment 232044 [details] Patch
Anders Carlsson
Comment 2 2014-05-25 15:30:51 PDT
Committed r169325: <http://trac.webkit.org/changeset/169325>
Darin Adler
Comment 3 2014-05-25 15:34:36 PDT
Comment on attachment 232044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232044&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:156 > + webContextConfiguration.localStorageDirectory = websiteDataDirectoryURL(@"LocalStorage").absoluteURL.path.fileSystemRepresentation; Another possible fix would be: websiteDataDirectoryURL(@"LocalStorage").absoluteURL.fileSystemRepresentation I don’t think there’s any need to call “path” explicitly. And unless it’s value to have these be relative URLs, I would expect that just: websiteDataDirectoryURL(@"LocalStorage").fileSystemRepresentation would work too.
Darin Adler
Comment 4 2014-05-25 15:35:09 PDT
(In reply to comment #3) > unless it’s value I think I meant "valid", or "expected", here.
Anders Carlsson
Comment 5 2014-05-25 18:06:00 PDT
(In reply to comment #3) > (From update of attachment 232044 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232044&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:156 > > + webContextConfiguration.localStorageDirectory = websiteDataDirectoryURL(@"LocalStorage").absoluteURL.path.fileSystemRepresentation; > > Another possible fix would be: > > websiteDataDirectoryURL(@"LocalStorage").absoluteURL.fileSystemRepresentation > > I don’t think there’s any need to call “path” explicitly. And unless it’s value to have these be relative URLs, I would expect that just: > > websiteDataDirectoryURL(@"LocalStorage").fileSystemRepresentation > > would work too. It would, except -[NSURL fileSystemRepresentation] isn't available on 10.8.
Darin Adler
Comment 6 2014-05-25 19:39:29 PDT
Comment on attachment 232044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232044&action=review >>> Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:156 >>> + webContextConfiguration.localStorageDirectory = websiteDataDirectoryURL(@"LocalStorage").absoluteURL.path.fileSystemRepresentation; >> >> Another possible fix would be: >> >> websiteDataDirectoryURL(@"LocalStorage").absoluteURL.fileSystemRepresentation >> >> I don’t think there’s any need to call “path” explicitly. And unless it’s value to have these be relative URLs, I would expect that just: >> >> websiteDataDirectoryURL(@"LocalStorage").fileSystemRepresentation >> >> would work too. > > It would, except -[NSURL fileSystemRepresentation] isn't available on 10.8. Oh, got it.
Note You need to log in before you can comment on or make changes to this bug.