[WebKit2] Rework WebPreferencesStore to allow easier overriding of defaults
Created attachment 232022 [details] Patch
Attachment 232022 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/WebPreferencesStore.cpp:158: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/Shared/WebPreferencesStore.cpp:159: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/Shared/WebPreferencesStore.cpp:160: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/Shared/WebPreferencesStore.cpp:161: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:353: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:354: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:355: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:356: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:357: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:382: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 10 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 232022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232022&action=review > Source/WebKit2/Shared/WebPreferencesStore.cpp:122 > + } Should have a default case that returns false. > Source/WebKit2/Shared/WebPreferencesStore.h:386 > + if (m_type == Type::String) > + m_string.~String(); Maybe you can factor this out into a private destroy() member function... > Source/WebKit2/Shared/WebPreferencesStore.h:412 > + if (m_type == Type::String) > + m_string.~String(); ...and call it here too.
Committed r169321: <http://trac.webkit.org/changeset/169321>