Bug 133258 - [WebKit2] Rework WebPreferencesStore to allow easier overriding of defaults
Summary: [WebKit2] Rework WebPreferencesStore to allow easier overriding of defaults
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-24 11:37 PDT by Sam Weinig
Modified: 2014-05-25 12:00 PDT (History)
1 user (show)

See Also:


Attachments
Patch (18.86 KB, patch)
2014-05-24 11:46 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-05-24 11:37:37 PDT
[WebKit2] Rework WebPreferencesStore to allow easier overriding of defaults
Comment 1 Sam Weinig 2014-05-24 11:46:32 PDT
Created attachment 232022 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-24 11:49:13 PDT
Attachment 232022 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/WebPreferencesStore.cpp:158:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/Shared/WebPreferencesStore.cpp:159:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/Shared/WebPreferencesStore.cpp:160:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/Shared/WebPreferencesStore.cpp:161:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:353:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:354:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:355:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:356:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:357:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebKit2/Shared/WebPreferencesStore.h:382:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 10 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-05-24 15:49:46 PDT
Comment on attachment 232022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232022&action=review

> Source/WebKit2/Shared/WebPreferencesStore.cpp:122
> +    }

Should have a default case that returns false.

> Source/WebKit2/Shared/WebPreferencesStore.h:386
> +            if (m_type == Type::String)
> +                m_string.~String();

Maybe you can factor this out into a private destroy() member function...

> Source/WebKit2/Shared/WebPreferencesStore.h:412
> +            if (m_type == Type::String)
> +                m_string.~String();

...and call it here too.
Comment 4 Sam Weinig 2014-05-25 12:00:07 PDT
Committed r169321: <http://trac.webkit.org/changeset/169321>