Bug 133254 - Rename ScrollingTreeScrollingNode's m_scrollPosition to make it clear that it's the value committed from the state tree
Summary: Rename ScrollingTreeScrollingNode's m_scrollPosition to make it clear that it...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-23 20:55 PDT by Simon Fraser (smfr)
Modified: 2014-05-24 13:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.27 KB, patch)
2014-05-23 20:56 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-05-23 20:55:16 PDT 
Rename ScrollingTreeScrollingNode's m_scrollPosition to make it clear that it's the value committed from the state tree
Comment 1 Simon Fraser (smfr) 2014-05-23 20:56:33 PDT 
Created attachment 232015 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-05-23 20:56:59 PDT 
Sits on top of an earlier patch.
Comment 3 Tim Horton 2014-05-23 21:01:01 PDT 
Comment on attachment 232015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232015&action=review

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:62
> +        m_lastCommittedcrollPosition = state.scrollPosition();

where did the s go
Comment 4 Simon Fraser (smfr) 2014-05-24 13:41:15 PDT 
https://trac.webkit.org/r169313