Bug 133253 - REGRESSION: Rubberbanding out jumps to top left corner on google.com
Summary: REGRESSION: Rubberbanding out jumps to top left corner on google.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-23 20:50 PDT by Ian Henderson
Modified: 2014-05-23 22:50 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch (1.71 KB, patch)
2014-05-23 20:54 PDT, Ian Henderson 		benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Henderson 2014-05-23 20:50:18 PDT 
<rdar://problem/17025664> REGRESSION: Rubberbanding out jumps to top left corner on google.com
Comment 1 Ian Henderson 2014-05-23 20:54:42 PDT 
Created attachment 232014 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-05-23 20:56:24 PDT 
Attachment 232014 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:946:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ian Henderson 2014-05-23 20:58:56 PDT 
I haven't actually tested this yet.  It works fine in Safari, though.  Feel free to test it yourself before reviewing, or you can wait for me to finish updating my tree and building.
Comment 4 Benjamin Poulain 2014-05-23 21:29:53 PDT 
Comment on attachment 232014 [details]
proposed patch

Great find. I'll fix the style and land manually.
Comment 5 Ian Henderson 2014-05-23 21:32:51 PDT 
I finally finished building.  Seems to work!
Comment 6 Ian Henderson 2014-05-23 21:33:32 PDT 
(In reply to comment #4)
> (From update of attachment 232014 [details])
> Great find. I'll fix the style and land manually.

Sounds good, thanks!
Comment 7 Benjamin Poulain 2014-05-23 21:37:26 PDT 
Committed r169304: <http://trac.webkit.org/changeset/169304>
Comment 8 Benjamin Poulain 2014-05-23 22:50:36 PDT 
It works great :)