Bug 133240 - [Mac] preload AVAssetTrack properties before asking for them
Summary: [Mac] preload AVAssetTrack properties before asking for them
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: InRadar
Depends on:
Reported: 2014-05-23 16:25 PDT by Eric Carlson
Modified: 2014-05-25 00:00 PDT (History)
6 users (show)

See Also:

Proposed patch. (1.65 KB, patch)
2014-05-23 16:28 PDT, Eric Carlson
jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (1.50 KB, patch)
2014-05-24 23:24 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-05-23 16:25:41 PDT
r168979 started checking AVAssetTrack preferredTransform and naturalSize, so we should preload them along with the other track properties we use.
Comment 1 Eric Carlson 2014-05-23 16:26:21 PDT
Comment 2 Eric Carlson 2014-05-23 16:28:55 PDT
Created attachment 232001 [details]
Proposed patch.
Comment 3 WebKit Commit Bot 2014-05-23 16:30:58 PDT
Attachment 232001 [details] did not pass style-queue:

ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2558:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Jer Noble 2014-05-23 18:31:28 PDT
Comment on attachment 232001 [details]
Proposed patch.

Comment 5 Eric Carlson 2014-05-24 23:24:42 PDT
Created attachment 232030 [details]
Patch for landing.
Comment 6 WebKit Commit Bot 2014-05-25 00:00:46 PDT
Comment on attachment 232030 [details]
Patch for landing.

Clearing flags on attachment: 232030

Committed r169317: <http://trac.webkit.org/changeset/169317>