Bug 133238 - run-perf-tests should ignore whitespace lines when snarfing test output
Summary: run-perf-tests should ignore whitespace lines when snarfing test output
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks: TerrainPerf
  Show dependency tree / graph
 
Reported: 2014-05-23 15:13 PDT by Geoffrey Garen
Modified: 2014-05-23 19:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2014-05-23 15:14 PDT, Geoffrey Garen 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2014-05-23 15:13:10 PDT 
run-perf-tests should ignore whitespace lines when snarfing test output
Comment 1 Geoffrey Garen 2014-05-23 15:14:35 PDT 
Created attachment 231996 [details]
Patch
Comment 2 Geoffrey Garen 2014-05-23 15:37:44 PDT 
Committed r169286: <http://trac.webkit.org/changeset/169286>
Comment 3 Mark Hahnenberg 2014-05-23 16:29:57 PDT 
(In reply to comment #2)
> Committed r169286: <http://trac.webkit.org/changeset/169286>

It looks like this broke some webkitpy tests on the Mavericks WK2 Release bots:

For the output of the failing tests, see: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20(Tests)/builds/5931/steps/webkitpy-test/logs/stdio

For the history of when the tests started failing, see: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=25
Comment 4 Ryosuke Niwa 2014-05-23 19:07:17 PDT 
Fixed in http://trac.webkit.org/changeset/169289.