Bug 133226 - Disable external playback while video plays inline with mirroring.
Summary: Disable external playback while video plays inline with mirroring.
Status: RESOLVED DUPLICATE of bug 133829
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-23 10:37 PDT by Jeremy Jones
Modified: 2014-06-13 14:54 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.27 KB, patch)
2014-05-23 11:14 PDT, Jeremy Jones
eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (538.95 KB, application/zip)
2014-05-23 14:20 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (748.69 KB, application/zip)
2014-05-23 14:50 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-05-23 10:37:59 PDT
Disable external playback while video plays inline with mirroring.
Comment 1 Jeremy Jones 2014-05-23 11:14:09 PDT
Created attachment 231974 [details]
Patch
Comment 2 Eric Carlson 2014-05-23 12:54:23 PDT
Comment on attachment 231974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231974&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2327
> +    UIScreenType *mainScreen = [UIScreen mainScreen];
> +    for (UIScreenType *screen in [UIScreen screens]) {
> +        if (![screen isEqual:mainScreen] && [screen.mirroredScreen isEqual:mainScreen]) {
> +            isMainScreenMirrored = true;
> +            break;
> +        }
> +    }

Nit: you can skip this if when in fullscreen.
Comment 3 Build Bot 2014-05-23 14:20:29 PDT
Comment on attachment 231974 [details]
Patch

Attachment 231974 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6176511719636992

New failing tests:
media/media-fragments/TC0001.html
Comment 4 Build Bot 2014-05-23 14:20:32 PDT
Created attachment 231986 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-05-23 14:50:37 PDT
Comment on attachment 231974 [details]
Patch

Attachment 231974 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4941080214634496

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 6 Build Bot 2014-05-23 14:50:40 PDT
Created attachment 231993 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Jeremy Jones 2014-06-13 14:54:57 PDT
superseded by: 133829

*** This bug has been marked as a duplicate of bug 133829 ***