WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 133829
133226
Disable external playback while video plays inline with mirroring.
https://bugs.webkit.org/show_bug.cgi?id=133226
Summary
Disable external playback while video plays inline with mirroring.
Jeremy Jones
Reported
2014-05-23 10:37:59 PDT
Disable external playback while video plays inline with mirroring.
Attachments
Patch
(5.27 KB, patch)
2014-05-23 11:14 PDT
,
Jeremy Jones
eric.carlson
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
(538.95 KB, application/zip)
2014-05-23 14:20 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
(748.69 KB, application/zip)
2014-05-23 14:50 PDT
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Jeremy Jones
Comment 1
2014-05-23 11:14:09 PDT
Created
attachment 231974
[details]
Patch
Eric Carlson
Comment 2
2014-05-23 12:54:23 PDT
Comment on
attachment 231974
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231974&action=review
> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2327 > + UIScreenType *mainScreen = [UIScreen mainScreen]; > + for (UIScreenType *screen in [UIScreen screens]) { > + if (![screen isEqual:mainScreen] && [screen.mirroredScreen isEqual:mainScreen]) { > + isMainScreenMirrored = true; > + break; > + } > + }
Nit: you can skip this if when in fullscreen.
Build Bot
Comment 3
2014-05-23 14:20:29 PDT
Comment on
attachment 231974
[details]
Patch
Attachment 231974
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/6176511719636992
New failing tests: media/media-fragments/TC0001.html
Build Bot
Comment 4
2014-05-23 14:20:32 PDT
Created
attachment 231986
[details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 5
2014-05-23 14:50:37 PDT
Comment on
attachment 231974
[details]
Patch
Attachment 231974
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/4941080214634496
New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 6
2014-05-23 14:50:40 PDT
Created
attachment 231993
[details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Jeremy Jones
Comment 7
2014-06-13 14:54:57 PDT
superseded by: 133829 *** This bug has been marked as a duplicate of
bug 133829
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug