Bug 133221 - navigator object needs to have properties directly on the instance object
Summary: navigator object needs to have properties directly on the instance object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-23 09:58 PDT by Oliver Hunt
Modified: 2016-02-16 13:08 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2014-05-23 10:02 PDT, Oliver Hunt 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2014-05-23 09:58:35 PDT 
navigator object needs to have properties directly on the instance object
Comment 1 Oliver Hunt 2014-05-23 10:02:16 PDT 
Created attachment 231970 [details]
Patch
Comment 2 Mark Lam 2014-05-23 10:05:00 PDT 
Comment on attachment 231970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231970&action=review

r=me with comment fix.

> Source/WebCore/ChangeLog:9
> +        as there were a few compatability issues when on the prototype.

s/compatability/compatibility/
Comment 3 Alexey Proskuryakov 2014-05-23 10:07:02 PDT 
Comment on attachment 231970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231970&action=review

>> Source/WebCore/ChangeLog:9
>> +        as there were a few compatability issues when on the prototype.
> 
> s/compatability/compatibility/

Is there a way to discover what the issues were (perhaps a Radar?)
Comment 4 Oliver Hunt 2014-05-23 10:08:52 PDT 
Committed r169260: <http://trac.webkit.org/changeset/169260>
Comment 5 Oliver Hunt 2014-05-23 10:10:12 PDT 
rdar://16332749
Comment 6 Mark Hahnenberg 2014-05-23 11:10:32 PDT 
(In reply to comment #4)
> Committed r169260: <http://trac.webkit.org/changeset/169260>

This appears to have broken the following tests on the WK2 bots:

fast/dom/Geolocation/enabled.html
js/dom/delete-syntax.html

Here's a link to the test results: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r169260%20(5917)/results.html

Here's a link to the history of test results: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=25