WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133205
[iOS] WK2: Provide implementation for windowFrame
https://bugs.webkit.org/show_bug.cgi?id=133205
Summary
[iOS] WK2: Provide implementation for windowFrame
Brent Fulgham
Reported
2014-05-22 22:34:03 PDT
The WK2 layer for iOS was missing an implementation for windowRect, causing DOMWindow::outerWidth and DOMWindow::outerHeight to always return 0, 0.
Attachments
Patch.
(2.73 KB, patch)
2014-05-22 22:41 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch
(2.78 KB, patch)
2014-05-23 14:22 PDT
,
Brent Fulgham
benjamin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-05-22 22:34:22 PDT
<
rdar://problem/16894890
>
Brent Fulgham
Comment 2
2014-05-22 22:37:50 PDT
And by windowRect I meant windowFrame.
Brent Fulgham
Comment 3
2014-05-22 22:41:00 PDT
Created
attachment 231942
[details]
Patch.
Benjamin Poulain
Comment 4
2014-05-23 02:06:21 PDT
Comment on
attachment 231942
[details]
Patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=231942&action=review
Let's talk about it tomorrow. After reading
http://www.quirksmode.org/blog/archives/2012/03/windowouterwidt.html
it looks like we have an extra bug to fix on WebKit1... :(
> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:252 > + return WebCore::enclosingIntRect(m_uiDelegate.m_webView.frame);
I think you want to the bounds, not the frame. We should have an extra step here: -Try to get the UIWindow from the WebView. If there is a window, return that size. -If there is not window, return the WebView bounds.
> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:309 > + FloatRect userRect(rect); > + userRect.scale(m_webView->_page->deviceScaleFactor()); > + return userRect;
Sorry, that's my fault. When you said we need to convert the rect to user space, I thought you meant in the WebProcess to convert to ContentCoordinates. This is not right. I think you can just return the incoming rect here on iOS.
Brent Fulgham
Comment 5
2014-05-23 14:22:39 PDT
Created
attachment 231988
[details]
Patch
Benjamin Poulain
Comment 6
2014-05-23 14:24:42 PDT
Comment on
attachment 231988
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231988&action=review
> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:252 > + UIWindow* window = m_uiDelegate.m_webView.window;
if (UIWindow* window = m_uiDelegate.m_webView.window) ...
> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:312 > + return rect; // Nothing to do on iOS
Missing period. But I think you should remove the comment.
Brent Fulgham
Comment 7
2014-05-23 14:33:10 PDT
Committed
r169281
: <
http://trac.webkit.org/changeset/169281
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug