Bug 133193 - Potential null dereference in WebFrameLoaderClient::dispatchDidFailProvisionalLoad()
Summary: Potential null dereference in WebFrameLoaderClient::dispatchDidFailProvisiona...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-22 17:01 PDT by Jon Honeycutt
Modified: 2014-05-27 14:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.03 KB, patch)
2014-05-22 17:07 PDT, Jon Honeycutt 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2014-05-22 17:01:59 PDT 
WebFrameLoaderClient::dispatchDidFailProvisionalLoad() calls the InjectedBundleLoaderClient's didFailProvisionalLoadWithErrorForFrame() before sending a message to the UI process that a provisional load has failed. It's possible for the provisional document loader to become null while calling into the InjectedBundleLoaderClient (as is the case with the WebKitTestRunner's injected bundle), leading to a null dereference when trying to send the DidFailProvisionalLoadForFrame message.
Comment 1 Jon Honeycutt 2014-05-22 17:07:02 PDT 
Created attachment 231921 [details]
Patch
Comment 2 Brady Eidson 2014-05-23 09:43:05 PDT 
Comment on attachment 231921 [details]
Patch

Any way to API test this?
Comment 3 Jon Honeycutt 2014-05-23 17:34:05 PDT 
(In reply to comment #2)
> (From update of attachment 231921 [details])
> Any way to API test this?

Yes, I think so. I'm working on that now.
Comment 4 WebKit Commit Bot 2014-05-24 20:31:26 PDT 
Comment on attachment 231921 [details]
Patch

Clearing flags on attachment: 231921

Committed r169315: <http://trac.webkit.org/changeset/169315>
Comment 5 WebKit Commit Bot 2014-05-24 20:31:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2014-05-27 14:00:52 PDT 
<rdar://problem/17042850>