RESOLVED FIXED 133193
Potential null dereference in WebFrameLoaderClient::dispatchDidFailProvisionalLoad()
https://bugs.webkit.org/show_bug.cgi?id=133193
Summary Potential null dereference in WebFrameLoaderClient::dispatchDidFailProvisiona...
Jon Honeycutt
Reported 2014-05-22 17:01:59 PDT
WebFrameLoaderClient::dispatchDidFailProvisionalLoad() calls the InjectedBundleLoaderClient's didFailProvisionalLoadWithErrorForFrame() before sending a message to the UI process that a provisional load has failed. It's possible for the provisional document loader to become null while calling into the InjectedBundleLoaderClient (as is the case with the WebKitTestRunner's injected bundle), leading to a null dereference when trying to send the DidFailProvisionalLoadForFrame message.
Attachments
Patch (4.03 KB, patch)
2014-05-22 17:07 PDT, Jon Honeycutt
no flags
Jon Honeycutt
Comment 1 2014-05-22 17:07:02 PDT
Brady Eidson
Comment 2 2014-05-23 09:43:05 PDT
Comment on attachment 231921 [details] Patch Any way to API test this?
Jon Honeycutt
Comment 3 2014-05-23 17:34:05 PDT
(In reply to comment #2) > (From update of attachment 231921 [details]) > Any way to API test this? Yes, I think so. I'm working on that now.
WebKit Commit Bot
Comment 4 2014-05-24 20:31:26 PDT
Comment on attachment 231921 [details] Patch Clearing flags on attachment: 231921 Committed r169315: <http://trac.webkit.org/changeset/169315>
WebKit Commit Bot
Comment 5 2014-05-24 20:31:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2014-05-27 14:00:52 PDT
Note You need to log in before you can comment on or make changes to this bug.