Bug 133191 – Eliminate n/total progress update from run-jsc-stress-tests output to file

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Michael Saboff]

When running a run-jsc-stress-tests test, you will see n/total output updated as tests complete.  For example
 123/1302

This is implemented with  printf "\r ${index}/${total}"

The inclusion of the '\r' complicates logging to a file.  We should eliminate this output when we aren't writing to a terminal.

[Michael Saboff]

Created attachment 231929 [details]
Patch

[Geoffrey Garen]

Comment on attachment 231929 [details]
Patch

r=me

[Michael Saboff]

Committed r169241: <http://trac.webkit.org/changeset/169241>

[Csaba Osztrogonác]

(In reply to comment #3)
> Committed r169241: <http://trac.webkit.org/changeset/169241>

It broke the jsc-stress-tests on the EFL ARM testers:

Tools/Scripts/run-jsc-stress-tests:1240:in `popen': can't convert Array into String (TypeError)
	from Tools/Scripts/run-jsc-stress-tests:1240:in `runAndMonitorTestRunnerCommand'
	from Tools/Scripts/run-jsc-stress-tests:1324:in `runMakeTestRunner'
	from Tools/Scripts/run-jsc-stress-tests:1321:in `chdir'
	from Tools/Scripts/run-jsc-stress-tests:1321:in `runMakeTestRunner'
	from Tools/Scripts/run-jsc-stress-tests:1210:in `runTestRunner'
	from Tools/Scripts/run-jsc-stress-tests:1382:in `runNormal'
	from Tools/Scripts/run-jsc-stress-tests:1412

ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux]
(Stock Ruby on Ubuntu 12.04)

[Michael Saboff]

(In reply to comment #4)
> (In reply to comment #3)
> > Committed r169241: <http://trac.webkit.org/changeset/169241>
> 
> It broke the jsc-stress-tests on the EFL ARM testers:
> 
> Tools/Scripts/run-jsc-stress-tests:1240:in `popen': can't convert Array into String (TypeError)
>     from Tools/Scripts/run-jsc-stress-tests:1240:in `runAndMonitorTestRunnerCommand'
>     from Tools/Scripts/run-jsc-stress-tests:1324:in `runMakeTestRunner'
>     from Tools/Scripts/run-jsc-stress-tests:1321:in `chdir'
>     from Tools/Scripts/run-jsc-stress-tests:1321:in `runMakeTestRunner'
>     from Tools/Scripts/run-jsc-stress-tests:1210:in `runTestRunner'
>     from Tools/Scripts/run-jsc-stress-tests:1382:in `runNormal'
>     from Tools/Scripts/run-jsc-stress-tests:1412
> 
> ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux]
> (Stock Ruby on Ubuntu 12.04)

The popen API works with Ruby 2.0.  I'll make it work by converting the array to a string.

[Michael Saboff]

Fix for regression landed in r169265: <http://trac.webkit.org/changeset/169265>

[Csaba Osztrogonác]

(In reply to comment #6)
> Fix for regression landed in r169265: <http://trac.webkit.org/changeset/169265>

Thanks for the fix.