Bug 133191 - Eliminate n/total progress update from run-jsc-stress-tests output to file
Summary: Eliminate n/total progress update from run-jsc-stress-tests output to file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on: 133223
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-22 14:20 PDT by Michael Saboff
Modified: 2014-05-27 03:03 PDT (History)
1 user (show)

See Also:

Attachments
Patch (8.60 KB, patch)
2014-05-22 18:21 PDT, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-05-22 14:20:47 PDT 
When running a run-jsc-stress-tests test, you will see n/total output updated as tests complete.  For example
 123/1302

This is implemented with  printf "\r ${index}/${total}"

The inclusion of the '\r' complicates logging to a file.  We should eliminate this output when we aren't writing to a terminal.
Comment 1 Michael Saboff 2014-05-22 18:21:53 PDT 
Created attachment 231929 [details]
Patch
Comment 2 Geoffrey Garen 2014-05-22 19:00:26 PDT 
Comment on attachment 231929 [details]
Patch

r=me
Comment 3 Michael Saboff 2014-05-22 20:28:12 PDT 
Committed r169241: <http://trac.webkit.org/changeset/169241>
Comment 4 Csaba Osztrogonác 2014-05-22 22:43:05 PDT 
(In reply to comment #3)
> Committed r169241: <http://trac.webkit.org/changeset/169241>

It broke the jsc-stress-tests on the EFL ARM testers:

Tools/Scripts/run-jsc-stress-tests:1240:in `popen': can't convert Array into String (TypeError)
	from Tools/Scripts/run-jsc-stress-tests:1240:in `runAndMonitorTestRunnerCommand'
	from Tools/Scripts/run-jsc-stress-tests:1324:in `runMakeTestRunner'
	from Tools/Scripts/run-jsc-stress-tests:1321:in `chdir'
	from Tools/Scripts/run-jsc-stress-tests:1321:in `runMakeTestRunner'
	from Tools/Scripts/run-jsc-stress-tests:1210:in `runTestRunner'
	from Tools/Scripts/run-jsc-stress-tests:1382:in `runNormal'
	from Tools/Scripts/run-jsc-stress-tests:1412

ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux]
(Stock Ruby on Ubuntu 12.04)
Comment 5 Michael Saboff 2014-05-22 23:00:36 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > Committed r169241: <http://trac.webkit.org/changeset/169241>
> 
> It broke the jsc-stress-tests on the EFL ARM testers:
> 
> Tools/Scripts/run-jsc-stress-tests:1240:in `popen': can't convert Array into String (TypeError)
>     from Tools/Scripts/run-jsc-stress-tests:1240:in `runAndMonitorTestRunnerCommand'
>     from Tools/Scripts/run-jsc-stress-tests:1324:in `runMakeTestRunner'
>     from Tools/Scripts/run-jsc-stress-tests:1321:in `chdir'
>     from Tools/Scripts/run-jsc-stress-tests:1321:in `runMakeTestRunner'
>     from Tools/Scripts/run-jsc-stress-tests:1210:in `runTestRunner'
>     from Tools/Scripts/run-jsc-stress-tests:1382:in `runNormal'
>     from Tools/Scripts/run-jsc-stress-tests:1412
> 
> ruby 1.8.7 (2011-06-30 patchlevel 352) [x86_64-linux]
> (Stock Ruby on Ubuntu 12.04)

The popen API works with Ruby 2.0.  I'll make it work by converting the array to a string.
Comment 6 Michael Saboff 2014-05-23 11:07:50 PDT 
Fix for regression landed in r169265: <http://trac.webkit.org/changeset/169265>
Comment 7 Csaba Osztrogonác 2014-05-27 03:03:52 PDT 
(In reply to comment #6)
> Fix for regression landed in r169265: <http://trac.webkit.org/changeset/169265>

Thanks for the fix.