Bug 133181 - [EFL] Input fields and text areas are not rendered correctly after r167771
Summary: [EFL] Input fields and text areas are not rendered correctly after r167771
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michal Pakula vel Rutka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-22 08:45 PDT by Michal Pakula vel Rutka
Modified: 2014-05-26 02:50 PDT (History)
8 users (show)

See Also:


Attachments
proposed patch (13.80 KB, patch)
2014-05-23 08:40 PDT, Michal Pakula vel Rutka
gyuyoung.kim: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (661.96 KB, application/zip)
2014-05-23 13:16 PDT, Build Bot
no flags Details
applied Christophe's suggestion (13.80 KB, patch)
2014-05-26 00:07 PDT, Michal Pakula vel Rutka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2014-05-22 08:45:35 PDT
Layout ref-test fast/forms/textarea-placeholder-wrapping.html is failing since r167771 <http://trac.webkit.org/changeset/167771>

Test output:
http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r169190%20%2814692%29/fast/forms/textarea-placeholder-wrapping-diffs.html
Comment 1 Michal Pakula vel Rutka 2014-05-23 08:40:11 PDT
Created attachment 231964 [details]
proposed patch

r167771 introduced changes in methods in parent (RenderTheme) class which were not reflected in derived class (RenderThemeEfl)
Comment 2 Build Bot 2014-05-23 13:16:17 PDT
Comment on attachment 231964 [details]
proposed patch

Attachment 231964 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4660147745980416

New failing tests:
media/W3C/video/readyState/readyState_during_canplay.html
Comment 3 Build Bot 2014-05-23 13:16:21 PDT
Created attachment 231978 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Gyuyoung Kim 2014-05-25 20:14:45 PDT
Comment on attachment 231964 [details]
proposed patch

Looks fine.
Comment 5 Chris Dumez 2014-05-25 20:37:13 PDT
Comment on attachment 231964 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231964&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.h:66
>      ~RenderThemeEfl();

nit: would be nice to mark this destructor explicitly as virtual since you are cleaning up.
Comment 6 Michal Pakula vel Rutka 2014-05-26 00:07:15 PDT
Created attachment 232062 [details]
applied Christophe's suggestion
Comment 7 WebKit Commit Bot 2014-05-26 02:50:48 PDT
Comment on attachment 232062 [details]
applied Christophe's suggestion

Clearing flags on attachment: 232062

Committed r169335: <http://trac.webkit.org/changeset/169335>
Comment 8 WebKit Commit Bot 2014-05-26 02:50:53 PDT
All reviewed patches have been landed.  Closing bug.