Bug 133181 – [EFL] Input fields and text areas are not rendered correctly after r167771

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Michal Pakula vel Rutka]

Layout ref-test fast/forms/textarea-placeholder-wrapping.html is failing since r167771 <http://trac.webkit.org/changeset/167771>

Test output:
http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r169190%20%2814692%29/fast/forms/textarea-placeholder-wrapping-diffs.html

[Michal Pakula vel Rutka]

Created attachment 231964 [details]
proposed patch

r167771 introduced changes in methods in parent (RenderTheme) class which were not reflected in derived class (RenderThemeEfl)

[Build Bot]

Comment on attachment 231964 [details]
proposed patch

Attachment 231964 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4660147745980416

New failing tests:
media/W3C/video/readyState/readyState_during_canplay.html

[Build Bot]

Created attachment 231978 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Gyuyoung Kim]

Comment on attachment 231964 [details]
proposed patch

Looks fine.

[Chris Dumez]

Comment on attachment 231964 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231964&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.h:66
>      ~RenderThemeEfl();

nit: would be nice to mark this destructor explicitly as virtual since you are cleaning up.

[Michal Pakula vel Rutka]

Created attachment 232062 [details]
applied Christophe's suggestion

[WebKit Commit Bot]

Comment on attachment 232062 [details]
applied Christophe's suggestion

Clearing flags on attachment: 232062

Committed r169335: <http://trac.webkit.org/changeset/169335>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.