Bug 133177 - Text markers don't paint on simple lines
Summary: Text markers don't paint on simple lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-22 05:50 PDT by Antti Koivisto
Modified: 2014-05-27 23:59 PDT (History)
7 users (show)

See Also:

Attachments
patch (7.42 KB, patch)
2014-05-22 05:55 PDT, Antti Koivisto 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-05-22 05:50:48 PDT 
Find markers are missing.
Comment 1 Antti Koivisto 2014-05-22 05:55:38 PDT 
Created attachment 231879 [details]
patch
Comment 2 Antti Koivisto 2014-05-22 06:06:21 PDT 
https://trac.webkit.org/r169199
Comment 3 Csaba Osztrogonác 2014-05-22 08:38:53 PDT 
(In reply to comment #1)
> Created an attachment (id=231879) [details]
> patch

It broke the Apple Windows build:

     1>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: void __thiscall WebCore::Editor::setMarkedTextMatchesAreHighlighted(bool)" (?setMarkedTextMatchesAreHighlighted@Editor@WebCore@@QAEX_N@Z) referenced in function "public: void __thiscall WebCore::Internals::setMarkedTextMatchesAreHighlighted(bool,int &)" (?setMarkedTextMatchesAreHighlighted@Internals@WebCore@@QAEX_NAAH@Z)
     1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(607,5): error MSB6006: "link.exe" exited with code 1120.
     1>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin32\DumpRenderTree.dll : fatal error LNK1120: 1 unresolved externals
     1>Done Building Project "C:\cygwin\home\buildbot\slave\win-release\build\Tools\DumpRenderTree\DumpRenderTree.vcxproj\DumpRenderTree\DumpRenderTree.vcxproj" (Build target(s)) -- FAILED.
Comment 4 Csaba Osztrogonác 2014-05-22 22:26:41 PDT 
The Windows build is still broken. Are you going to fix it?
Comment 5 Csaba Osztrogonác 2014-05-23 02:22:35 PDT 
(In reply to comment #4)
> The Windows build is still broken. Are you going to fix it?

http://trac.webkit.org/changeset/169253 fixed the build, thanks.
Comment 6 Tim Horton 2014-05-27 23:59:29 PDT 
<rdar://problem/16911387>