Bug 133176 - W3C test importer should catch exceptions coming from HTML/CSS conversion
Summary: W3C test importer should catch exceptions coming from HTML/CSS conversion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-22 05:31 PDT by youenn fablet
Modified: 2014-05-26 23:48 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.14 KB, patch)
2014-05-22 05:43 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (3.14 KB, patch)
2014-05-22 06:01 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2014-05-22 05:31:31 PDT
Test case W3C test html/semantics/forms/the-input-element/radio-groupname-case.html breaks W3C test importer.
An exception is raised within python 2.7 HTMLParser.
This stops the conversion process.
It may be better to catch the exception, log it and continue importing the remaining tests.
Comment 1 youenn fablet 2014-05-22 05:43:07 PDT
Created attachment 231877 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-22 05:45:53 PDT
Attachment 231877 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/w3c/test_importer.py:346:  trailing whitespace  [pep8/W291] [5]
ERROR: Tools/Scripts/webkitpy/w3c/test_importer.py:350:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 youenn fablet 2014-05-22 06:01:04 PDT
Created attachment 231880 [details]
Patch
Comment 4 WebKit Commit Bot 2014-05-26 09:11:46 PDT
Comment on attachment 231880 [details]
Patch

Clearing flags on attachment: 231880

Committed r169347: <http://trac.webkit.org/changeset/169347>
Comment 5 WebKit Commit Bot 2014-05-26 09:11:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Carlos Alberto Lopez Perez 2014-05-26 16:15:15 PDT
(In reply to comment #3)
> Created an attachment (id=231880) [details]
> Patch

(In reply to comment #4)
> (From update of attachment 231880 [details])
> Clearing flags on attachment: 231880
> 
> Committed r169347: <http://trac.webkit.org/changeset/169347>


This broke the webkitpy tests on all platforms: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/6279
Comment 7 youenn fablet 2014-05-26 23:48:21 PDT
(In reply to comment #6)
> (In reply to comment #3)
> > Created an attachment (id=231880) [details] [details]
> > Patch
> 
> (In reply to comment #4)
> > (From update of attachment 231880 [details] [details])
> > Clearing flags on attachment: 231880
> > 
> > Committed r169347: <http://trac.webkit.org/changeset/169347>
> 
> 
> This broke the webkitpy tests on all platforms: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/6279

Gyuyoung fixed it at http://trac.webkit.org/changeset/169369