Bug 133175 - Captions layout incorrectly in fullscreen.
Summary: Captions layout incorrectly in fullscreen.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-22 01:11 PDT by Jeremy Jones
Modified: 2014-05-28 10:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2014-05-22 01:20 PDT, Jeremy Jones 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch (5.28 KB, patch)
2014-05-22 11:01 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-05-22 01:11:15 PDT 
Captions layout incorrectly in fullscreen.
Comment 1 Jeremy Jones 2014-05-22 01:20:25 PDT 
Created attachment 231868 [details]
Patch
Comment 2 Jeremy Jones 2014-05-22 01:21:07 PDT 
radar://16923830
Comment 3 Eric Carlson 2014-05-22 06:36:42 PDT 
Comment on attachment 231868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231868&action=review

> Source/WebCore/html/shadow/MediaControlElements.cpp:1366
>              setInlineStyleProperty(CSSPropertyWidth, m_videoDisplaySize.size().width(), CSSPrimitiveValue::CSS_PX);
>              setInlineStyleProperty(CSSPropertyHeight, m_videoDisplaySize.size().height(), CSSPrimitiveValue::CSS_PX);
> +            setInlineStyleProperty(CSSPropertyPosition, CSSValueAbsolute);
> +            setInlineStyleProperty(CSSPropertyLeft, 0, CSSPrimitiveValue::CSS_PX);
> +            setInlineStyleProperty(CSSPropertyTop, 0, CSSPrimitiveValue::CSS_PX);

Nit: this should be in a member function instead of being duplicated here and in updateTimerFired.
Comment 4 Jeremy Jones 2014-05-22 11:01:22 PDT 
Created attachment 231896 [details]
Patch
Comment 5 WebKit Commit Bot 2014-05-22 18:05:16 PDT 
Comment on attachment 231896 [details]
Patch

Clearing flags on attachment: 231896

Committed r169234: <http://trac.webkit.org/changeset/169234>