Start 7: test_ewk2_back_forward_list 7/68 Test #7: test_ewk2_back_forward_list ........................***Failed 2.92 sec Xlib: extension "DPMS" missing on display ":55". [==========] Running 7 tests from 1 test case. [----------] Global test environment set-up. [----------] 7 tests from EWK2BackForwardListTest [ RUN ] EWK2BackForwardListTest.ewk_back_forward_list_current_item_get [ OK ] EWK2BackForwardListTest.ewk_back_forward_list_current_item_get (367 ms) [ RUN ] EWK2BackForwardListTest.ewk_back_forward_list_previous_item_get /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:108: Failure Value of: ewk_view_title_get(webView()) Actual: "ERROR: The requested URL could not be retrieved" Expected: title1 Which is: "Page1" [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_previous_item_get (379 ms) [ RUN ] EWK2BackForwardListTest.ewk_back_forward_list_next_item_get /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:129: Failure Value of: ewk_view_title_get(webView()) Actual: "ERROR: The requested URL could not be retrieved" Expected: title1 Which is: "Page1" [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_next_item_get (329 ms) [ RUN ] EWK2BackForwardListTest.ewk_back_forward_list_item_at_index_get /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:156: Failure Value of: ewk_view_title_get(webView()) Actual: "ERROR: The requested URL could not be retrieved" Expected: title1 Which is: "Page1" [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_item_at_index_get (328 ms) [ RUN ] EWK2BackForwardListTest.ewk_back_forward_list_count /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:180: Failure Value of: ewk_view_title_get(webView()) Actual: "ERROR: The requested URL could not be retrieved" Expected: title1 Which is: "Page1" [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_count (327 ms) [ RUN ] EWK2BackForwardListTest.ewk_back_forward_list_n_back_items_copy /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:198: Failure Value of: ewk_view_title_get(webView()) Actual: "ERROR: The requested URL could not be retrieved" Expected: title1 Which is: "Page1" [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_n_back_items_copy (373 ms) [ RUN ] EWK2BackForwardListTest.ewk_back_forward_list_n_forward_items_copy /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:234: Failure Value of: ewk_view_title_get(webView()) Actual: "ERROR: The requested URL could not be retrieved" Expected: title1 Which is: "Page1" [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_n_forward_items_copy (363 ms) [----------] 7 tests from EWK2BackForwardListTest (2467 ms total) [----------] Global test environment tear-down [==========] 7 tests from 1 test case ran. (2467 ms total) [ PASSED ] 1 test. [ FAILED ] 6 tests, listed below: [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_previous_item_get [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_next_item_get [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_item_at_index_get [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_count [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_n_back_items_copy [ FAILED ] EWK2BackForwardListTest.ewk_back_forward_list_n_forward_items_copy 6 FAILED TESTS
Created attachment 231861 [details] Patch Use local test html pages instead of EWK2UnitTestServer for ewk2_back_forward_list tests.
Comment on attachment 231861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231861&action=review Thanks for fixing it. The patch itself looks good to me. Please consider adding some details to ChangeLog. > Source/WebKit2/ChangeLog:3 > + [WebKit2-EFL] Fix EWK2BackForwardListTest test fails Nit: generally we use [EFL][WK2] prefix. > Source/WebKit2/ChangeLog:8 > + Use local test html pages instead of EWK2UnitTestServer for ewk2_back_forward_list tests. Could you mention in ChangeLog why this change is needed (why can not EWK2UnitTestServer load the page properly)? I believe that, this note will encourage reviewers to have a look at the patch.
Created attachment 231870 [details] Patch-Updated Updated the changeLog file, as per review comments.
Comment on attachment 231870 [details] Patch-Updated View in context: https://bugs.webkit.org/attachment.cgi?id=231870&action=review > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:-48 > - unsigned int width = environment->defaultWidth(); Would you mind submitting those code style changes in a separate patch since those are not connected with the failures?
Created attachment 231872 [details] Patch-Updated-Review Removed the code style changes updated in old patch ( 231870).
Comment on attachment 231872 [details] Patch-Updated-Review Thanks for updates. Seems fine to me.
Comment on attachment 231872 [details] Patch-Updated-Review View in context: https://bugs.webkit.org/attachment.cgi?id=231872&action=review LGTM > Source/WebKit2/ChangeLog:3 > + [EFL] [WK2] Fix EWK2BackForwardListTest test fails ditto.
Created attachment 232107 [details] Patch for landing
Comment on attachment 232107 [details] Patch for landing Clearing flags on attachment: 232107 Committed r169367: <http://trac.webkit.org/changeset/169367>
All reviewed patches have been landed. Closing bug.
Bug is fixed, tested in version 169584.