Bug 133170 - [WebKit2-EFL] Fix code style check errors in EFL API tests
Summary: [WebKit2-EFL] Fix code style check errors in EFL API tests
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-21 22:38 PDT by Shivakumar J M
Modified: 2014-06-04 02:45 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2014-05-22 21:10 PDT, Shivakumar J M 		no flags Details | Formatted Diff | Diff
Patch for landing (2.57 KB, patch)
2014-05-26 20:48 PDT, Shivakumar J M 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shivakumar J M 2014-05-21 22:38:50 PDT 
Found below errors, when run ./Tools/Scripts/check-webkit-style  on Source/WebKit2/UIProcess/API/efl/.


ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:48:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:49:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:44:  There was more than one newline at the end of the file.  [whitespace/ending_newline] [5]
ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:38:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:39:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:42:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:43:  Omit int when using unsigned  [runtime/unsigned] [1]
Comment 1 Shivakumar J M 2014-05-22 21:10:52 PDT 
Created attachment 231937 [details]
Patch

Omit int when using unsigned modifier, as per coding style rules.
Comment 2 Gyuyoung Kim 2014-05-26 02:03:19 PDT 
Comment on attachment 231937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231937&action=review

LGTM

> Source/WebKit2/ChangeLog:3
> +        [EFL] [WK2] Fix code style check errors in EFL API tests

nit: an necessary space between [EFL] and [WK2].
Comment 3 Shivakumar J M 2014-05-26 20:48:24 PDT 
Created attachment 232106 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2014-05-26 21:33:03 PDT 
Comment on attachment 232106 [details]
Patch for landing

Clearing flags on attachment: 232106

Committed r169366: <http://trac.webkit.org/changeset/169366>
Comment 5 WebKit Commit Bot 2014-05-26 21:33:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Shivakumar J M 2014-06-04 02:45:45 PDT 
Bug is fixed, tested in version 169584.