WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
133169
Don't create huge backing stores when transforms cause layer scaling
https://bugs.webkit.org/show_bug.cgi?id=133169
Summary
Don't create huge backing stores when transforms cause layer scaling
Simon Fraser (smfr)
Reported
2014-05-21 22:25:15 PDT
Don't create huge backing stores when transforms cause layer scaling
Attachments
Patch
(28.05 KB, patch)
2014-05-21 22:30 PDT
,
Simon Fraser (smfr)
thorton
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
(639.01 KB, application/zip)
2014-05-22 07:49 PDT
,
Build Bot
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2014-05-21 22:30:20 PDT
<
rdar://problem/16864666
>
Simon Fraser (smfr)
Comment 2
2014-05-21 22:30:32 PDT
Created
attachment 231857
[details]
Patch
Tim Horton
Comment 3
2014-05-22 00:32:19 PDT
Comment on
attachment 231857
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231857&action=review
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2170 > + for (size_t i = 0; i < animations.size(); ++i) {
range-based for?
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2172 > + runningAnimations.remove(currAnimationName);
can you use the iterator from earlier?
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2443 > + for (auto it = animations.begin(); it != animations.end(); ++it) {
range-based for here too, maybe?
Build Bot
Comment 4
2014-05-22 07:49:24 PDT
Comment on
attachment 231857
[details]
Patch
Attachment 231857
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/6102868599767040
New failing tests: media/media-source/media-source-addsourcebuffer.html
Build Bot
Comment 5
2014-05-22 07:49:28 PDT
Created
attachment 231886
[details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Simon Fraser (smfr)
Comment 6
2014-05-22 17:42:33 PDT
Comment on
attachment 231857
[details]
Patch Not going to do this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug