Bug 133166 - [ftlopt] DFG::clobberize should be blind to the effects of GC
Summary: [ftlopt] DFG::clobberize should be blind to the effects of GC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-21 20:47 PDT by Filip Pizlo
Modified: 2014-05-21 21:43 PDT (History)
13 users (show)

See Also:

Attachments
the patch (20.70 KB, patch)
2014-05-21 20:55 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-05-21 20:47:33 PDT 
Clobberization should only be used during the earlier parts of compilation, when it's fair game to insert allocations anywhere.  This change will allow for hoisting of MakeRope's.
Comment 1 Filip Pizlo 2014-05-21 20:55:46 PDT 
Created attachment 231851 [details]
the patch
Comment 2 Geoffrey Garen 2014-05-21 20:58:45 PDT 
Comment on attachment 231851 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231851&action=review

r=me

> Source/JavaScriptCore/dfg/DFGDoesGC.cpp:37
> +    switch (node->op()) {

Might be nice to list all the ops here explicitly, and remove the default. That would make it impossible to add a new op without considering whether it does GC.
Comment 3 Filip Pizlo 2014-05-21 20:59:47 PDT 
(In reply to comment #2)
> (From update of attachment 231851 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231851&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGDoesGC.cpp:37
> > +    switch (node->op()) {
> 
> Might be nice to list all the ops here explicitly, and remove the default. That would make it impossible to add a new op without considering whether it does GC.

True.  I'll do that.
Comment 4 Filip Pizlo 2014-05-21 21:11:59 PDT 
Landed in http://trac.webkit.org/changeset/169188
Comment 5 Andreas Kling 2014-05-21 21:43:10 PDT 
(In reply to comment #0)
> This change will allow for hoisting of MakeRope's.

I love you.