Bug 133166 – [ftlopt] DFG::clobberize should be blind to the effects of GC

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Clobberization should only be used during the earlier parts of compilation, when it's fair game to insert allocations anywhere.  This change will allow for hoisting of MakeRope's.

[Filip Pizlo]

Created attachment 231851 [details]
the patch

[Geoffrey Garen]

Comment on attachment 231851 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231851&action=review

r=me

> Source/JavaScriptCore/dfg/DFGDoesGC.cpp:37
> +    switch (node->op()) {

Might be nice to list all the ops here explicitly, and remove the default. That would make it impossible to add a new op without considering whether it does GC.

[Filip Pizlo]

(In reply to comment #2)
> (From update of attachment 231851 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231851&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGDoesGC.cpp:37
> > +    switch (node->op()) {
> 
> Might be nice to list all the ops here explicitly, and remove the default. That would make it impossible to add a new op without considering whether it does GC.

True.  I'll do that.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/169188

[Andreas Kling]

(In reply to comment #0)
> This change will allow for hoisting of MakeRope's.

I love you.