Bug 133159 – viewStateDidChange should always fully update ViewState

• Status: ASSIGNED
• Component: WebKit2

[Gavin Barraclough]

Currently WebPageProxy::viewStateDidChange is passed a mask of bits to update.

This has the following negative consequences:
 – WKWebView implicitly requires more detailed knowledge of the internal implementation of the PageClient.
 – Updates may unnecessarily be split over multiple IPC messages.
 – In order to support partial updates we make multiple virtual function calls to PageClient, which then makes duplicate objc calls.

Better to just always update the entire ViewState.

[Gavin Barraclough]

Created attachment 232099 [details]
Fix

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Sam Weinig]

Look good to me, but I would like Anders to review it as well.

[Gavin Barraclough]

Created attachment 232100 [details]
gtk/efl fix

[Carlos Garcia Campos]

Comment on attachment 232100 [details]
gtk/efl fix

View in context: https://bugs.webkit.org/attachment.cgi?id=232100&action=review

Thanks for fixing the GTK+ port too.

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:110
> +    if (webkitWebViewBaseIsFocused(WEBKIT_WEB_VIEW_BASE(m_viewWidget)))
> +        viewState |= ViewState::IsFocused;
> +    if (webkitWebViewBaseIsInWindowActive(WEBKIT_WEB_VIEW_BASE(m_viewWidget)))
> +        viewState |= ViewState::WindowIsActive;
> +    if (webkitWebViewBaseIsInWindow(WEBKIT_WEB_VIEW_BASE(m_viewWidget)))
> +        viewState |= ViewState::IsInWindow;
> +    if (webkitWebViewBaseIsVisible(WEBKIT_WEB_VIEW_BASE(m_viewWidget)))

Now that all these are in the same function, I would use a local variable to avoid casting all the time.
WebKitWebViewBase* webView = WEBKIT_WEB_VIEW_BASE(m_viewWidget);

if (webkitWebViewBaseIsFocused(webView))
....

I think it also improves a bit the readability.

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:70
> +    bool isViewVisible();

Why re-adding this as non-virtual?

[Anders Carlsson]

Comment on attachment 232100 [details]
gtk/efl fix

This looks really great, but please address the comments from Carlos.

[Gavin Barraclough]

(In reply to comment #5)
> (From update of attachment 232100 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232100&action=review
> 
> Thanks for fixing the GTK+ port too.
> 
> > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:110
> > +    if (webkitWebViewBaseIsFocused(WEBKIT_WEB_VIEW_BASE(m_viewWidget)))
> > +        viewState |= ViewState::IsFocused;
> > +    if (webkitWebViewBaseIsInWindowActive(WEBKIT_WEB_VIEW_BASE(m_viewWidget)))
> > +        viewState |= ViewState::WindowIsActive;
> > +    if (webkitWebViewBaseIsInWindow(WEBKIT_WEB_VIEW_BASE(m_viewWidget)))
> > +        viewState |= ViewState::IsInWindow;
> > +    if (webkitWebViewBaseIsVisible(WEBKIT_WEB_VIEW_BASE(m_viewWidget)))
> 
> Now that all these are in the same function, I would use a local variable to avoid casting all the time.
> WebKitWebViewBase* webView = WEBKIT_WEB_VIEW_BASE(m_viewWidget);
> 
> if (webkitWebViewBaseIsFocused(webView))
> ....
> 
> I think it also improves a bit the readability.
> 

Ah – yes, good point. Done.

> > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:70
> > +    bool isViewVisible();
> 
> Why re-adding this as non-virtual?

Ooops, remnants of a partial refactor – that's gone now, removed.

[Gavin Barraclough]

Transmitting file data .................
Committed revision 169439.

[Radar WebKit Bug Importer]

<rdar://problem/17069364>

[Babak Shafiei]

Roll out on trunk in https://trac.webkit.org/r169465