Bug 133157 - [GTK] Allow to run the tests on the native X display (instead of running them inside of Xvfb)
Summary: [GTK] Allow to run the tests on the native X display (instead of running them...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 132862 144247
  Show dependency treegraph
 
Reported: 2014-05-21 13:14 PDT by Carlos Alberto Lopez Perez
Modified: 2015-04-26 21:38 PDT (History)
10 users (show)

See Also:


Attachments
Patch (8.79 KB, patch)
2014-05-23 05:06 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (7.97 KB, patch)
2014-05-26 06:40 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (7.97 KB, patch)
2014-05-26 07:05 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2014-05-21 13:14:28 PDT
This is useful for the performance bot #132862. Running the tests inside of Xvfb don't seems a good idea to get real-world performance metrics.

EFL port implemented a feature like this on #131036
Comment 1 Carlos Alberto Lopez Perez 2014-05-23 05:06:00 PDT
Created attachment 231957 [details]
Patch
Comment 2 Benjamin Poulain 2014-05-23 11:15:26 PDT
Comment on attachment 231957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review

Quick questions

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131
> +            optparse.make_option("--nocheck-sys-deps", action="store_true", default=False,
> +            help="Don't check the system dependencies (themes, fonts, ...)"),

Is this really necessary?

> Tools/Scripts/webkitpy/port/driver.py:493
> +    def check_driver(port):

Where is it used?
Comment 3 Carlos Alberto Lopez Perez 2014-05-23 11:59:04 PDT
(In reply to comment #2)
> (From update of attachment 231957 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review
> 
> Quick questions
> 
> > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131
> > +            optparse.make_option("--nocheck-sys-deps", action="store_true", default=False,
> > +            help="Don't check the system dependencies (themes, fonts, ...)"),
> 
> Is this really necessary?
> 
Not strictly necessary, but is consistent with the script for running the layout tests run-webkit-tests:

$ Tools/Scripts/run-webkit-tests --help|grep sys
    --nocheck-sys-deps  Don't check the system dependencies (themes)

I can drop it, if you think is better.

> > Tools/Scripts/webkitpy/port/driver.py:493
> > +    def check_driver(port):
> 
> Where is it used?

Is used on the drivers Xvfb, Weston and this new one (xorgdriver):

Tools/Scripts/webkitpy/port/xvfbdriver.py
Tools/Scripts/webkitpy/port/westondriver.py
Comment 4 Benjamin Poulain 2014-05-23 18:29:35 PDT
Comment on attachment 231957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review

>>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131
>>> +            help="Don't check the system dependencies (themes, fonts, ...)"),
>> 
>> Is this really necessary?
> 
> Not strictly necessary, but is consistent with the script for running the layout tests run-webkit-tests:
> 
> $ Tools/Scripts/run-webkit-tests --help|grep sys
>     --nocheck-sys-deps  Don't check the system dependencies (themes)
> 
> I can drop it, if you think is better.

Unless it is necessary, let's drop this.
It is trivial to add later if needed.
Comment 5 Carlos Alberto Lopez Perez 2014-05-26 06:40:30 PDT
Created attachment 232074 [details]
Patch
Comment 6 Carlos Alberto Lopez Perez 2014-05-26 06:41:43 PDT
(In reply to comment #4)
> (From update of attachment 231957 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review
> 
> >>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131
> >>> +            help="Don't check the system dependencies (themes, fonts, ...)"),
> >> 
> >> Is this really necessary?
> > 
> > Not strictly necessary, but is consistent with the script for running the layout tests run-webkit-tests:
> > 
> > $ Tools/Scripts/run-webkit-tests --help|grep sys
> >     --nocheck-sys-deps  Don't check the system dependencies (themes)
> > 
> > I can drop it, if you think is better.
> 
> Unless it is necessary, let's drop this.
> It is trivial to add later if needed.

Thanks for your review :)

I have re-uploaded the patch without the "--nocheck-sys-deps" option
Comment 7 Carlos Alberto Lopez Perez 2014-05-26 07:05:52 PDT
Created attachment 232077 [details]
Patch
Comment 8 Carlos Alberto Lopez Perez 2014-05-26 07:08:08 PDT
(In reply to comment #7)
> Created an attachment (id=232077) [details]
> Patch

I have re-uploaded it again with the "Reviewed by" bit pre-filled on the Changelog.

Can someone cq+ it for me please?

Thanks!
Comment 9 WebKit Commit Bot 2014-05-26 07:20:24 PDT
Comment on attachment 232077 [details]
Patch

Clearing flags on attachment: 232077

Committed r169344: <http://trac.webkit.org/changeset/169344>
Comment 10 WebKit Commit Bot 2014-05-26 07:20:30 PDT
All reviewed patches have been landed.  Closing bug.