Bug 133138 - [Mac] DataCues do not work properly when rewinding video
Summary: [Mac] DataCues do not work properly when rewinding video
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 132715
Blocks:
  Show dependency tree / graph
 
Reported: 2014-05-20 14:46 PDT by Brent Fulgham
Modified: 2014-05-20 21:09 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.56 KB, patch)
2014-05-20 14:57 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (8.79 KB, patch)
2014-05-20 18:06 PDT, Brent Fulgham 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-05-20 14:46:11 PDT 
If you play a video that has embedded WebKitDataCue elements, the cues are displayed properly as you watch the video. However, if you rewind the video, the data cues are not re-displayed.
Comment 1 Brent Fulgham 2014-05-20 14:49:39 PDT 
This bug was introduced with Bug 132715 (Changeset <http://trac.webkit.org/changeset/168519>).

1. DataCue objects do not provide the correct startTimeVariance value for AVFoundation use.
2. The comparison in "hasEquivalentStartTime" should be "<=", rather than "<" to handle the case of zero startTimeVariance.
Comment 2 Radar WebKit Bug Importer 2014-05-20 14:52:00 PDT 
<rdar://problem/16979086>
Comment 3 Brent Fulgham 2014-05-20 14:57:52 PDT 
Created attachment 231796 [details]
Patch
Comment 4 Eric Carlson 2014-05-20 17:02:19 PDT 
Comment on attachment 231796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231796&action=review

Did you mean to mark this r? If so, this looks good to me modulo the TextTrack.h change I don't understand.

> Source/WebCore/html/track/TextTrack.h:162
> +    virtual double startTimeVariance() const { return 0; }
> +

Why is this needed?
Comment 5 Brent Fulgham 2014-05-20 18:06:14 PDT 
Created attachment 231804 [details]
Patch
Comment 6 Brent Fulgham 2014-05-20 19:21:21 PDT 
Comment on attachment 231796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231796&action=review

>> Source/WebCore/html/track/TextTrack.h:162
>> +
> 
> Why is this needed?

This patch wasn't complete. Please check the current one.
Comment 7 Brent Fulgham 2014-05-20 21:09:24 PDT 
Committed r169146: <http://trac.webkit.org/changeset/169146>