Bug 133135 - Watchdog timer should be lazily allocated
Summary: Watchdog timer should be lazily allocated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-20 14:01 PDT by Mark Hahnenberg
Modified: 2014-05-20 15:56 PDT (History)
1 user (show)

See Also:

Attachments
Patch (16.41 KB, patch)
2014-05-20 14:02 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-05-20 14:01:00 PDT 
We incur a noticeable amount of overhead on some benchmarks due to checking if the Watchdog ever fired. There is no reason to do this checking if we never activated the Watchdog, which can only be done through JSContextGroupSetExecutionTimeLimit or JSContextGroupClearExecutionTimeLimit. 

By allocating the Watchdog lazily on the VM we can avoid all of the associated overhead when we don't use these two API functions (which is true of most clients).
Comment 1 Mark Hahnenberg 2014-05-20 14:02:34 PDT 
Created attachment 231793 [details]
Patch
Comment 2 Geoffrey Garen 2014-05-20 14:07:58 PDT 
Comment on attachment 231793 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-05-20 15:56:19 PDT 
Comment on attachment 231793 [details]
Patch

Clearing flags on attachment: 231793

Committed r169139: <http://trac.webkit.org/changeset/169139>
Comment 4 WebKit Commit Bot 2014-05-20 15:56:22 PDT 
All reviewed patches have been landed.  Closing bug.