Bug 133129 - [Mac] Allow popup menus to override default appearance
Summary: [Mac] Allow popup menus to override default appearance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-20 12:54 PDT by Dean Jackson
Modified: 2014-05-20 14:08 PDT (History)
0 users

See Also:

Attachments
Patch (14.17 KB, patch)
2014-05-20 13:05 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-05-20 12:54:18 PDT 
[Mac] Allow popup menus to override default appearance
Comment 1 Dean Jackson 2014-05-20 12:54:50 PDT 
<rdar://problem/16881605>
Comment 2 Dean Jackson 2014-05-20 13:05:52 PDT 
Created attachment 231786 [details]
Patch
Comment 3 Dean Jackson 2014-05-20 13:06:18 PDT 
This patch will not compile until WKSI is updated.
Comment 4 Tim Horton 2014-05-20 13:09:51 PDT 
Comment on attachment 231786 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231786&action=review

> Source/WebCore/platform/PopupMenuStyle.h:46
> -    PopupMenuStyle(const Color& foreground, const Color& background, const Font& font, bool visible, bool isDisplayNone, Length textIndent, TextDirection textDirection, bool hasTextDirectionOverride, BackgroundColorType backgroundColorType = DefaultBackgroundColor, PopupMenuType menuType = SelectPopup, PopupMenuSize menuSize = PopupMenuSizeNormal)
> +    PopupMenuStyle(const Color& foreground, const Color& background, const Font& font, bool visible, bool isDisplayNone, bool hasDefaultAppearance, Length textIndent, TextDirection textDirection, bool hasTextDirectionOverride, BackgroundColorType backgroundColorType = DefaultBackgroundColor, PopupMenuType menuType = SelectPopup, PopupMenuSize menuSize = PopupMenuSizeNormal)

yikes. this could really use some cleaning up.
Comment 5 Dean Jackson 2014-05-20 14:08:06 PDT 
Committed r169134: <http://trac.webkit.org/changeset/169134>