WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133129
[Mac] Allow popup menus to override default appearance
https://bugs.webkit.org/show_bug.cgi?id=133129
Summary
[Mac] Allow popup menus to override default appearance
Dean Jackson
Reported
2014-05-20 12:54:18 PDT
[Mac] Allow popup menus to override default appearance
Attachments
Patch
(14.17 KB, patch)
2014-05-20 13:05 PDT
,
Dean Jackson
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dean Jackson
Comment 1
2014-05-20 12:54:50 PDT
<
rdar://problem/16881605
>
Dean Jackson
Comment 2
2014-05-20 13:05:52 PDT
Created
attachment 231786
[details]
Patch
Dean Jackson
Comment 3
2014-05-20 13:06:18 PDT
This patch will not compile until WKSI is updated.
Tim Horton
Comment 4
2014-05-20 13:09:51 PDT
Comment on
attachment 231786
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231786&action=review
> Source/WebCore/platform/PopupMenuStyle.h:46 > - PopupMenuStyle(const Color& foreground, const Color& background, const Font& font, bool visible, bool isDisplayNone, Length textIndent, TextDirection textDirection, bool hasTextDirectionOverride, BackgroundColorType backgroundColorType = DefaultBackgroundColor, PopupMenuType menuType = SelectPopup, PopupMenuSize menuSize = PopupMenuSizeNormal) > + PopupMenuStyle(const Color& foreground, const Color& background, const Font& font, bool visible, bool isDisplayNone, bool hasDefaultAppearance, Length textIndent, TextDirection textDirection, bool hasTextDirectionOverride, BackgroundColorType backgroundColorType = DefaultBackgroundColor, PopupMenuType menuType = SelectPopup, PopupMenuSize menuSize = PopupMenuSizeNormal)
yikes. this could really use some cleaning up.
Dean Jackson
Comment 5
2014-05-20 14:08:06 PDT
Committed
r169134
: <
http://trac.webkit.org/changeset/169134
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug