Bug 133127 - [Mac] do not deactivate an audio session that has running I/O
Summary: [Mac] do not deactivate an audio session that has running I/O
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-20 12:35 PDT by Eric Carlson
Modified: 2014-05-20 13:52 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (6.65 KB, patch)
2014-05-20 12:45 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-05-20 12:35:44 PDT 
MediaSessionManager calls AudioSession::sharedSession().setActive(false) when there are no active WebAudio sessions. It should not do this if there are any Audio or Video sessions.
Comment 1 Eric Carlson 2014-05-20 12:36:03 PDT 
<rdar://problem/16876590>
Comment 2 Eric Carlson 2014-05-20 12:45:09 PDT 
Created attachment 231784 [details]
Proposed patch
Comment 3 Jer Noble 2014-05-20 13:09:45 PDT 
Comment on attachment 231784 [details]
Proposed patch

r=me
Comment 4 WebKit Commit Bot 2014-05-20 13:52:50 PDT 
Comment on attachment 231784 [details]
Proposed patch

Clearing flags on attachment: 231784

Committed r169130: <http://trac.webkit.org/changeset/169130>
Comment 5 WebKit Commit Bot 2014-05-20 13:52:54 PDT 
All reviewed patches have been landed.  Closing bug.