Bug 133094 - fix assertion failure in PerformanceTiming::responseStart
Summary: fix assertion failure in PerformanceTiming::responseStart
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-19 16:48 PDT by Alex Christensen
Modified: 2014-05-20 10:30 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2014-05-19 16:52 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2014-05-19 17:07 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-05-19 16:48:38 PDT
Sometimes responseStart is still -1 when the timing data from CFNetwork is 0.  This should fix the assertion failure.
Comment 1 Alex Christensen 2014-05-19 16:52:39 PDT
Created attachment 231737 [details]
Patch
Comment 2 Alex Christensen 2014-05-19 17:07:13 PDT
Created attachment 231739 [details]
Patch
Comment 3 Alexey Proskuryakov 2014-05-20 09:52:53 PDT
Comment on attachment 231739 [details]
Patch

Is this covered by any regression tests?
Comment 4 WebKit Commit Bot 2014-05-20 10:30:05 PDT
Comment on attachment 231739 [details]
Patch

Clearing flags on attachment: 231739

Committed r169119: <http://trac.webkit.org/changeset/169119>
Comment 5 WebKit Commit Bot 2014-05-20 10:30:07 PDT
All reviewed patches have been landed.  Closing bug.