Bug 133092 – REGRESSION: Standalone images need to take topContentInset into account

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Beth Dakin]

Standalone images taller than the viewport are scaled to a size slightly taller than the viewport when there is a topContentInset.

<rdar://problem/16945791>

[Beth Dakin]

Created attachment 231735 [details]
Patch

[Benjamin Poulain]

Comment on attachment 231735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231735&action=review

> Source/WebCore/html/ImageDocument.cpp:283
> +    IntSize viewportSize = view->visibleSize();

Doesn't this also account for the scale factor?

[Beth Dakin]

(In reply to comment #2)
> (From update of attachment 231735 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231735&action=review
> 
> > Source/WebCore/html/ImageDocument.cpp:283
> > +    IntSize viewportSize = view->visibleSize();
> 
> Doesn't this also account for the scale factor?

I don't see any differences introduced by this change based on scale factor.

[Beth Dakin]

(In reply to comment #2)
> (From update of attachment 231735 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231735&action=review
> 
> > Source/WebCore/html/ImageDocument.cpp:283
> > +    IntSize viewportSize = view->visibleSize();
> 
> Doesn't this also account for the scale factor?

Oh, and to more directly answer the question, it does not take scale factor into account. It ends up calling unscaledUnobscuredVisibleContentSize().

[Beth Dakin]

Thanks, Darin!

http://trac.webkit.org/changeset/169084