WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133089
[iOS] REGRESSION (
r168910
): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
https://bugs.webkit.org/show_bug.cgi?id=133089
Summary
[iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --s...
David Kilzer (:ddkilzer)
Reported
2014-05-19 15:55:01 PDT
If both '--sdk SDKROOT' and '--sim' are specified on the command line, we would remove the '--sdk' arguments, but leave '--sim', potentially passing it along to xcodebuild causing a build failure. This happens when 'old-run-webkit-tests --release --sim' invokes build-dumprendertree when DumpRenderTree hasn't been built yet.
Attachments
Patch v1
(1.90 KB, patch)
2014-05-19 16:00 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2014-05-19 15:58:40 PDT
This is technically a regression from
r168910
: [iOS] Support TestWebKitAPI in the iOS Simulator <
http://webkit.org/b/129535
>
David Kilzer (:ddkilzer)
Comment 2
2014-05-19 16:00:23 PDT
Created
attachment 231731
[details]
Patch v1
WebKit Commit Bot
Comment 3
2014-05-19 17:44:31 PDT
Comment on
attachment 231731
[details]
Patch v1 Clearing flags on attachment: 231731 Committed
r169088
: <
http://trac.webkit.org/changeset/169088
>
WebKit Commit Bot
Comment 4
2014-05-19 17:44:34 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug