Bug 133089 - [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
Summary: [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --s...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on: 129535
  Show dependency treegraph
Reported: 2014-05-19 15:55 PDT by David Kilzer (:ddkilzer)
Modified: 2014-05-19 17:44 PDT (History)
5 users (show)

See Also:

Patch v1 (1.90 KB, patch)
2014-05-19 16:00 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-05-19 15:55:01 PDT
If both '--sdk SDKROOT' and '--sim' are specified on the command line, we would remove the '--sdk' arguments, but leave '--sim', potentially passing it along to xcodebuild causing a build failure.  This happens when 'old-run-webkit-tests --release --sim' invokes build-dumprendertree when DumpRenderTree hasn't been built yet.
Comment 1 David Kilzer (:ddkilzer) 2014-05-19 15:58:40 PDT
This is technically a regression from r168910:

    [iOS] Support TestWebKitAPI in the iOS Simulator
Comment 2 David Kilzer (:ddkilzer) 2014-05-19 16:00:23 PDT
Created attachment 231731 [details]
Patch v1
Comment 3 WebKit Commit Bot 2014-05-19 17:44:31 PDT
Comment on attachment 231731 [details]
Patch v1

Clearing flags on attachment: 231731

Committed r169088: <http://trac.webkit.org/changeset/169088>
Comment 4 WebKit Commit Bot 2014-05-19 17:44:34 PDT
All reviewed patches have been landed.  Closing bug.