WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133088
Make fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html reliable
https://bugs.webkit.org/show_bug.cgi?id=133088
Summary
Make fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemov...
David Kilzer (:ddkilzer)
Reported
2014-05-19 15:48:45 PDT
When running fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html on iOS WebKit with the WebThread, we need to make sure to wait until the second inserted script has run.
Attachments
Patch v1
(3.50 KB, patch)
2014-05-19 15:51 PDT
,
David Kilzer (:ddkilzer)
ap
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2014-05-19 15:51:01 PDT
Created
attachment 231728
[details]
Patch v1
Darin Adler
Comment 2
2014-05-19 17:28:54 PDT
Comment on
attachment 231728
[details]
Patch v1 Wouldn’t we have to do this for all tests? I’m not sure this is the right solution to this problem. Can’t we fix it in DumpRenderTree instead?
Alexey Proskuryakov
Comment 3
2014-05-19 18:06:28 PDT
Comment on
attachment 231728
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=231728&action=review
> LayoutTests/ChangeLog:11 > + - Use waitUntilDone()/notifyDone() to make the tests reliable on > + iOS with the WebThread enabled.
I think that there is nothing special about iOS DumpRendreTree here - these tests have a setTimeout that races with parsing. They could fail on OS X as well.
David Kilzer (:ddkilzer)
Comment 4
2014-05-20 07:47:42 PDT
Committed
r169111
: <
http://trac.webkit.org/changeset/169111
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug