RESOLVED FIXED 133075
collect web timing data on iOS
https://bugs.webkit.org/show_bug.cgi?id=133075
Summary collect web timing data on iOS
Alex Christensen
Reported 2014-05-19 10:40:55 PDT
I collect web timing data from CFNetwork on Mac, and we should do something similar on iOS to make the web timing data more complete.
Attachments
Patch (17.85 KB, patch)
2014-05-19 10:47 PDT, Alex Christensen
no flags
Patch (17.80 KB, patch)
2014-05-19 10:53 PDT, Alex Christensen
no flags
Patch (18.68 KB, patch)
2014-05-19 12:10 PDT, Alex Christensen
sam: review+
Alex Christensen
Comment 1 2014-05-19 10:47:10 PDT
Alex Christensen
Comment 2 2014-05-19 10:53:53 PDT
Simon Fraser (smfr)
Comment 3 2014-05-19 10:55:16 PDT
Comment on attachment 231701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231701&action=review > Source/WebCore/platform/network/ResourceHandle.h:141 > + static void getTimingData(NSDictionary *, ResourceLoadTiming&); > + static void getTimingData(CFDictionaryRef, ResourceLoadTiming&); These are a bit confusing, Why not: static void getConnectionTimingData(CFURLConnectionRef, ResourceLoadTiming&).
Alex Christensen
Comment 4 2014-05-19 10:57:53 PDT
(In reply to comment #3) > (From update of attachment 231701 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231701&action=review > > > Source/WebCore/platform/network/ResourceHandle.h:141 > > + static void getTimingData(NSDictionary *, ResourceLoadTiming&); > > + static void getTimingData(CFDictionaryRef, ResourceLoadTiming&); > > These are a bit confusing, Why not: static void getConnectionTimingData(CFURLConnectionRef, ResourceLoadTiming&). One is already used on osx, which uses a NSURLConnection from which I can get a NSDictionary*. One is going to be used with iOS which uses CFNetwork, and I can only get a CFDictionaryRef. It is a bit confusing, but that's how the data is available.
Alex Christensen
Comment 5 2014-05-19 12:10:53 PDT
Sam Weinig
Comment 6 2014-05-19 16:39:52 PDT
Comment on attachment 231707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231707&action=review > Source/WebCore/platform/network/mac/ResourceHandleMac.mm:715 > + if (timingData) { Do an early return here.
Alex Christensen
Comment 7 2014-05-19 16:46:55 PDT
Note You need to log in before you can comment on or make changes to this bug.