I collect web timing data from CFNetwork on Mac, and we should do something similar on iOS to make the web timing data more complete.
Created attachment 231701 [details] Patch
Created attachment 231702 [details] Patch
Comment on attachment 231701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231701&action=review > Source/WebCore/platform/network/ResourceHandle.h:141 > + static void getTimingData(NSDictionary *, ResourceLoadTiming&); > + static void getTimingData(CFDictionaryRef, ResourceLoadTiming&); These are a bit confusing, Why not: static void getConnectionTimingData(CFURLConnectionRef, ResourceLoadTiming&).
(In reply to comment #3) > (From update of attachment 231701 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231701&action=review > > > Source/WebCore/platform/network/ResourceHandle.h:141 > > + static void getTimingData(NSDictionary *, ResourceLoadTiming&); > > + static void getTimingData(CFDictionaryRef, ResourceLoadTiming&); > > These are a bit confusing, Why not: static void getConnectionTimingData(CFURLConnectionRef, ResourceLoadTiming&). One is already used on osx, which uses a NSURLConnection from which I can get a NSDictionary*. One is going to be used with iOS which uses CFNetwork, and I can only get a CFDictionaryRef. It is a bit confusing, but that's how the data is available.
Created attachment 231707 [details] Patch
Comment on attachment 231707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231707&action=review > Source/WebCore/platform/network/mac/ResourceHandleMac.mm:715 > + if (timingData) { Do an early return here.
http://trac.webkit.org/changeset/169082