Bug 133070 – Remove unused JSC runtime options

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Zsolt Borbely]

Remove unused JSC runtime options.

[Zsolt Borbely]

Created attachment 231691 [details]
Proposed patch

[Csaba Osztrogonác]

Comment on attachment 231691 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231691&action=review

> Source/JavaScriptCore/runtime/Options.h:-149
> -    v(bool, enableExperimentalFTLCoverage, false) \

It is unused now, but we shouldn't remove it until FTL is complete.
I think JSC developers will need this to add new experimental features.

> Source/JavaScriptCore/runtime/Options.h:-197
> -    v(unsigned, maximumInliningDepthForMustInline, 7) \
> -    v(unsigned, maximumInliningRecursionForMustInline, 3) \

These options were introduced by the cstack merge and were unused from the beginning.
Were they used only for developing in the branch?

[Csaba Osztrogonác]

Comment on attachment 231691 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231691&action=review

>> Source/JavaScriptCore/runtime/Options.h:-149
>> -    v(bool, enableExperimentalFTLCoverage, false) \
> 
> It is unused now, but we shouldn't remove it until FTL is complete.
> I think JSC developers will need this to add new experimental features.

It is still unused. Can we remove it?

>> Source/JavaScriptCore/runtime/Options.h:-197
>> -    v(unsigned, maximumInliningRecursionForMustInline, 3) \
> 
> These options were introduced by the cstack merge and were unused from the beginning.
> Were they used only for developing in the branch?

After a half year later, I still can't find any use of maximumInliningDepthForMustInline and maximumInliningRecursionForMustInline
in the full git history. I think they aren't used ever. Any objection against removing them?

[Csaba Osztrogonác]

Comment on attachment 231691 [details]
Proposed patch

There were no objection, these option are really unused (and weren't used ever), so let's remove them, r=me.

[WebKit Commit Bot]

Comment on attachment 231691 [details]
Proposed patch

Rejecting attachment 231691 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 231691, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
2 (offset 13 lines).
Hunk #3 succeeded at 247 (offset 15 lines).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/run-jsc-stress-tests
Hunk #1 FAILED at 181.
Hunk #2 succeeded at 616 (offset 65 lines).
1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/run-jsc-stress-tests.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Csaba Osztrogon\xe1c']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6467577131827200

[Csaba Osztrogonác]

Committed r176716: <http://trac.webkit.org/changeset/176716>