Bug 133068 – Only set title on SVG documents

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Prashant Hiremath]

We should set title on only SVG documents, HTML document should not be affected.

Blink, IE and FF behaves similarly.

We should merge recent blink Merge https://src.chromium.org/viewvc/blink?revision=174123&view=revision

I'll update the patch soon...

[Prashant Hiremath]

Created attachment 231686 [details]
Patch

proposed patch

[Dirk Schulze]

(In reply to comment #0)
> We should set title on only SVG documents, HTML document should not be affected.
> 
> Blink, IE and FF behaves similarly.
> 
> We should merge recent blink Merge https://src.chromium.org/viewvc/blink?revision=174123&view=revision
> 
> I'll update the patch soon...

No we shouldn't. The SVG guidance still says that <title> can be set on groups and elements. In how far <title> is still important is questionable. Until then we should maybe fix title, but not just let it apply to document.

[Dirk Schulze]

Comment on attachment 231686 [details]
Patch

Totally misunderstood the purpose. r=me

[WebKit Commit Bot]

Comment on attachment 231686 [details]
Patch

Clearing flags on attachment: 231686

Committed r169118: <http://trac.webkit.org/changeset/169118>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Dirk Schulze]

Hm, I just noticed that is was back ported from Blink. These kind of things should be part of the ChangeLog and the original author should get the credits.