Bug 133062 – [WebKit2] Cleanup the build from unused variable in WebProcess module

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Shivakumar J M]

Found unused variable used in WebKit2/WebProcess/UserContent/WebUserContentController.cpp during webkit-efl port build.

/home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:142:6: warning: unused parameter ‘scriptMessageHandlers’ [-Wunused-parameter]
 void WebUserContentController::addUserScriptMessageHandlers(const Vector<WebScriptMessageHandlerHandle>& scriptMessageHandlers)
      ^
/home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:154:6: warning: unused parameter ‘identifier’ [-Wunused-parameter]
 void WebUserContentController::removeUserScriptMessageHandler(uint64_t identifier)

[Shivakumar J M]

Created attachment 231675 [details]
Patch

Fix unused parameter by using UNUSED_PARAM macro

[Csaba Osztrogonác]

Comment on attachment 231675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231675&action=review

> Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:144
> +    UNUSED_PARAM(scriptMessageHandlers);

scriptMessageHandlers is used if ENABLE(USER_MESSAGE_HANDLERS) 
is true, it should be placed in the #else case, like this:

#if ENABLE(USER_MESSAGE_HANDLERS)
   ...
#else
    UNUSED_PARAM(scriptMessageHandlers);
#endif

> Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:157
> +    UNUSED_PARAM(identifier);

ditto

[Shivakumar J M]

Created attachment 231749 [details]
Patch-Updated

Updated with review comments

[WebKit Commit Bot]

Comment on attachment 231749 [details]
Patch-Updated

Clearing flags on attachment: 231749

Committed r169152: <http://trac.webkit.org/changeset/169152>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Shivakumar J M]

Bug is fixed, tested in version 169584.

[Csaba Osztrogonác]

(In reply to comment #6)
> Bug is fixed, tested in version 169584.

Please don't change Resolved/fixed state of a bug to Verified/fixed.
Resolved/fixed is the final state of the bug reports.

(In reply to comment #4)
> (From update of attachment 231749 [details])
> Clearing flags on attachment: 231749
> 
> Committed r169152: <http://trac.webkit.org/changeset/169152>

It means that the bug is fixed, because the patch landed in this svn 
commit. There is no need for any testing / verifying after it.