WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133062
[WebKit2] Cleanup the build from unused variable in WebProcess module
https://bugs.webkit.org/show_bug.cgi?id=133062
Summary
[WebKit2] Cleanup the build from unused variable in WebProcess module
Shivakumar J M
Reported
2014-05-18 22:20:58 PDT
Found unused variable used in WebKit2/WebProcess/UserContent/WebUserContentController.cpp during webkit-efl port build. /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:142:6: warning: unused parameter ‘scriptMessageHandlers’ [-Wunused-parameter] void WebUserContentController::addUserScriptMessageHandlers(const Vector<WebScriptMessageHandlerHandle>& scriptMessageHandlers) ^ /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:154:6: warning: unused parameter ‘identifier’ [-Wunused-parameter] void WebUserContentController::removeUserScriptMessageHandler(uint64_t identifier)
Attachments
Patch
(1.88 KB, patch)
2014-05-18 22:29 PDT
,
Shivakumar J M
ossy
: review-
ossy
: commit-queue-
Details
Formatted Diff
Diff
Patch-Updated
(1.70 KB, patch)
2014-05-19 20:42 PDT
,
Shivakumar J M
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Shivakumar J M
Comment 1
2014-05-18 22:29:47 PDT
Created
attachment 231675
[details]
Patch Fix unused parameter by using UNUSED_PARAM macro
Csaba Osztrogonác
Comment 2
2014-05-19 05:31:25 PDT
Comment on
attachment 231675
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231675&action=review
> Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:144 > + UNUSED_PARAM(scriptMessageHandlers);
scriptMessageHandlers is used if ENABLE(USER_MESSAGE_HANDLERS) is true, it should be placed in the #else case, like this: #if ENABLE(USER_MESSAGE_HANDLERS) ... #else UNUSED_PARAM(scriptMessageHandlers); #endif
> Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:157 > + UNUSED_PARAM(identifier);
ditto
Shivakumar J M
Comment 3
2014-05-19 20:42:09 PDT
Created
attachment 231749
[details]
Patch-Updated Updated with review comments
WebKit Commit Bot
Comment 4
2014-05-21 01:13:20 PDT
Comment on
attachment 231749
[details]
Patch-Updated Clearing flags on attachment: 231749 Committed
r169152
: <
http://trac.webkit.org/changeset/169152
>
WebKit Commit Bot
Comment 5
2014-05-21 01:13:23 PDT
All reviewed patches have been landed. Closing bug.
Shivakumar J M
Comment 6
2014-06-04 02:45:09 PDT
Bug is fixed, tested in version 169584.
Csaba Osztrogonác
Comment 7
2014-06-04 02:49:23 PDT
(In reply to
comment #6
)
> Bug is fixed, tested in version 169584.
Please don't change Resolved/fixed state of a bug to Verified/fixed. Resolved/fixed is the final state of the bug reports. (In reply to
comment #4
)
> (From update of
attachment 231749
[details]
) > Clearing flags on attachment: 231749 > > Committed
r169152
: <
http://trac.webkit.org/changeset/169152
>
It means that the bug is fixed, because the patch landed in this svn commit. There is no need for any testing / verifying after it.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug