WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133061
Use RenderStyle& in more places in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=133061
Summary
Use RenderStyle& in more places in RenderLayerBacking
Simon Fraser (smfr)
Reported
2014-05-18 22:09:28 PDT
Use RenderStyle& in more places in RenderLayerBacking
Attachments
Patch
(16.01 KB, patch)
2014-05-18 22:10 PDT
,
Simon Fraser (smfr)
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2014-05-18 22:10:51 PDT
Created
attachment 231673
[details]
Patch
Andreas Kling
Comment 2
2014-05-18 23:20:15 PDT
Comment on
attachment 231673
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231673&action=review
r=me
> Source/WebCore/rendering/RenderLayerBacking.cpp:1519 > + const FillLayer* fillLayer = style.backgroundLayers();
Maybe we could make RenderStyle::backgroundLayers() return a FillLayer&, too. Then we'd get rid of even more ->'s.
Simon Fraser (smfr)
Comment 3
2014-05-19 08:49:38 PDT
(In reply to
comment #2
)
> (From update of
attachment 231673
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=231673&action=review
> > r=me > > > Source/WebCore/rendering/RenderLayerBacking.cpp:1519 > > + const FillLayer* fillLayer = style.backgroundLayers(); > > Maybe we could make RenderStyle::backgroundLayers() return a FillLayer&, too. > Then we'd get rid of even more ->'s.
I don't think we can. It may not have any.
Simon Fraser (smfr)
Comment 4
2014-05-19 08:54:34 PDT
http://trac.webkit.org/changeset/169046
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug