Bug 133061 - Use RenderStyle& in more places in RenderLayerBacking
Summary: Use RenderStyle& in more places in RenderLayerBacking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-18 22:09 PDT by Simon Fraser (smfr)
Modified: 2014-05-19 08:54 PDT (History)
1 user (show)

See Also:

Attachments
Patch (16.01 KB, patch)
2014-05-18 22:10 PDT, Simon Fraser (smfr) 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-05-18 22:09:28 PDT 
Use RenderStyle& in more places in RenderLayerBacking
Comment 1 Simon Fraser (smfr) 2014-05-18 22:10:51 PDT 
Created attachment 231673 [details]
Patch
Comment 2 Andreas Kling 2014-05-18 23:20:15 PDT 
Comment on attachment 231673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231673&action=review

r=me

> Source/WebCore/rendering/RenderLayerBacking.cpp:1519
> +    const FillLayer* fillLayer = style.backgroundLayers();

Maybe we could make RenderStyle::backgroundLayers() return a FillLayer&, too.
Then we'd get rid of even more ->'s.
Comment 3 Simon Fraser (smfr) 2014-05-19 08:49:38 PDT 
(In reply to comment #2)
> (From update of attachment 231673 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231673&action=review
> 
> r=me
> 
> > Source/WebCore/rendering/RenderLayerBacking.cpp:1519
> > +    const FillLayer* fillLayer = style.backgroundLayers();
> 
> Maybe we could make RenderStyle::backgroundLayers() return a FillLayer&, too.
> Then we'd get rid of even more ->'s.

I don't think we can. It may not have any.
Comment 4 Simon Fraser (smfr) 2014-05-19 08:54:34 PDT 
http://trac.webkit.org/changeset/169046