RESOLVED FIXED 133042
[ftlopt] Factor out how CallLinkStatus uses exit site data 
https://bugs.webkit.org/show_bug.cgi?id=133042
Summary [ftlopt] Factor out how CallLinkStatus uses exit site data
Filip Pizlo
Reported 2014-05-17 22:47:27 PDT
We need to query exit site data while holding a different lock then when we query all of the other data. Currently, CallLinkStatus knows what to query but it does so behind an opaque API that assumes that it's querying the CallLinkInfo for a op_call/op_construct instruction. This would make it difficult to integrate with a different Status class that wants to use a CallLinkInfo that is embedded inside a stub, like GetByIdStatus or PutByIdStatus - those will only see that there is a CallLinkInfo for which to compute status while they are already holding the "wrong" lock for computing exit site data. We should refactor things so that: - You can ask CallLinkStatus to compute exit site data - essentially an opaque data token - without giving it the CallLinkInfo. - You can pass the exit site data and the CallLinkInfo and get a complete CallLinkStatus. - Do what you do now - i.e. we shouldn't change the existing API that just does all of this for you.
Attachments
the patch (7.83 KB, patch)
2014-05-17 22:55 PDT, Filip Pizlo 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-05-17 22:55:49 PDT
Created attachment 231648 [details] the patch
Filip Pizlo
Comment 2 2014-05-18 10:33:29 PDT
Landed in http://trac.webkit.org/changeset/169014
Note You need to log in before you can comment on or make changes to this bug.