Created attachment 231624 [details]
Comment on attachment 231624 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=231624&action=review
> - m_repaintTimer.stop();
> + view().unscheduleLazyRepaint(*this);
Shouldn't it check the lazy repaint bit? Unscheduling does hash lookup and is expensive. Also we might want to not do this on full tree teardown.
> +void RenderView::scheduleLazyRepaint(RenderBox& renderer)
> + renderer.setRenderBoxNeedsLazyRepaint(true);
This could bail out if the bit is already set.
> +void RenderView::unscheduleLazyRepaint(RenderBox& renderer)
> + renderer.setRenderBoxNeedsLazyRepaint(false);
This could either assert or bail out if the bit is not set.
Created attachment 231625 [details]
That went really well. Let's try again!
Comment on attachment 231625 [details]
Clearing flags on attachment: 231625
Committed r168993: <http://trac.webkit.org/changeset/168993>
All reviewed patches have been landed. Closing bug.