Bug 133025 - PlatformCALayerRemoteCustom properties aren't initialized to match the PlatformLayer
Summary: PlatformCALayerRemoteCustom properties aren't initialized to match the Platfo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-16 21:52 PDT by Jeremy Jones
Modified: 2014-05-19 17:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2014-05-16 21:57 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2014-05-19 14:16 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-05-16 21:52:56 PDT
PlatformCALayerRemoteCustom properties aren't initialized to match the PlatformLayer
Comment 1 Jeremy Jones 2014-05-16 21:55:22 PDT
radar://16796474

After exiting fullscreen HTMLMediaElement's PlatformLayer may have a non-zero Position. The renderer creates PlatoformCALayerRemoteCustom for that layer with a default position of (0,0,0).  The renderer then sets the position to (0,0,0), which is ignore and the PlatformLayer's position is never updated.
Comment 2 Jeremy Jones 2014-05-16 21:57:55 PDT
Created attachment 231621 [details]
Patch
Comment 3 Jeremy Jones 2014-05-19 14:16:27 PDT
Created attachment 231721 [details]
Patch
Comment 4 Tim Horton 2014-05-19 14:25:12 PDT
Hmm, we should probably do all of them.
Comment 5 Jeremy Jones 2014-05-19 16:42:13 PDT
(In reply to comment #4)
> Hmm, we should probably do all of them.

I've filed: https://bugs.webkit.org/show_bug.cgi?id=133093 to cover initializing the rest of the properties.
Comment 6 WebKit Commit Bot 2014-05-19 17:19:11 PDT
Comment on attachment 231721 [details]
Patch

Clearing flags on attachment: 231721

Committed r169086: <http://trac.webkit.org/changeset/169086>
Comment 7 WebKit Commit Bot 2014-05-19 17:19:14 PDT
All reviewed patches have been landed.  Closing bug.