Bug 133024 – [Phone Number Detection] drop-down menu in the phone number detection box doesn't appear

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

The data detector menu was not working because the 'drawRects' function was clearing the set of selected phone numbers on each draw operation. This is wrong, because the drawRect function is called for each drawing tile. Since the screen often has ~9 tiles, and the last tile is likely to not have a phone number causing the set of selected phone numbers to get cleared.

[Brent Fulgham]

Created attachment 231620 [details]
Patch

[Brent Fulgham]

<rdar://problem/16917021>

[Sam Weinig]

Comment on attachment 231620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231620&action=review

> Source/WebKit2/ChangeLog:10
> +        time we call drawRect. This gets called ~9 times per screen refresh, so end up with no active

~9 times? That seems like a lot. Do we have a bug tracking why we are calling drawRect here so much?

[Brent Fulgham]

Comment on attachment 231620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231620&action=review

>> Source/WebKit2/ChangeLog:10
>> +        time we call drawRect. This gets called ~9 times per screen refresh, so end up with no active
> 
> ~9 times? That seems like a lot. Do we have a bug tracking why we are calling drawRect here so much?

Once per tile. It varies by how much of the screen is dirty, and how large the screen is. I think this is working as designed..

[WebKit Commit Bot]

Comment on attachment 231620 [details]
Patch

Clearing flags on attachment: 231620

Committed r168998: <http://trac.webkit.org/changeset/168998>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.