RESOLVED FIXED133017
Expose WKUserScript as API 
https://bugs.webkit.org/show_bug.cgi?id=133017
Summary Expose WKUserScript as API
Anders Carlsson
Reported 2014-05-16 16:18:14 PDT
Expose WKUserScript as API
Attachments
Patch (75.83 KB, patch)
2014-05-16 16:39 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-05-16 16:39:10 PDT
Created attachment 231604 [details] Patch
WebKit Commit Bot
Comment 2 2014-05-16 16:42:13 PDT
Attachment 231604 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKUserScriptInternal.h:32: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerInternal.h:36: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2014-05-16 17:53:09 PDT
Comment on attachment 231604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231604&action=review > Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h:41 > +class WebUserContentControllerProxy final : public RefCounted<WebUserContentControllerProxy> { There is nothing virtual about this class. Does adding final really help here? > Source/WebKit2/WebProcess/UserContent/WebUserContentController.h:51 > +private: This private is redundant. > Source/WebKit2/WebProcess/UserContent/WebUserContentController.h:53 > + RefPtr<WebCore::UserContentController> m_userContentController; This could probably be a Ref<WebCore::UserContentController> m_userContentController;
Anders Carlsson
Comment 4 2014-05-17 12:58:10 PDT
Committed r168994: <http://trac.webkit.org/changeset/168994>
Note You need to log in before you can comment on or make changes to this bug.